Skip to content

[mps] Hoist erfinv logic out of the kernel in preparation for moving. #145568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcci wants to merge 1 commit into from
Closed

[mps] Hoist erfinv logic out of the kernel in preparation for moving. #145568

dcci wants to merge 1 commit into from

Conversation

@dcci
Copy link
Member

@dcci dcci commented Jan 24, 2025 •
edited by pytorch-bot bot
Loading

@dcci dcci added topic: not user facing topic category module: mps Related to Apple Metal Performance Shaders framework ciflow/mps Run MPS tests (subset of trunk) module: inductor labels Jan 24, 2025
@dcci dcci requested a review from jansel January 24, 2025 00:46
@dcci dcci requested review from kulinseth and malfet as code owners January 24, 2025 00:46
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145568

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 45 Pending

As of commit db8b460 with merge base b808774 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dcci
Copy link
Member Author

dcci commented Jan 24, 2025

hmm, the CI is borked. I'll wait a bit before rerunning the tests (merging from main)

@dcci
Copy link
Member Author

dcci commented Jan 24, 2025

@pytorchbot merge -f "lint + mps tests green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 24, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

nWEIdia pushed a commit to nWEIdia/pytorch that referenced this pull request Jan 27, 2025
@dcci @nWEIdia
[mps] Hoist erfinv logic out of the kernel in preparation for moving. (…
d7ebc58 
…pytorch#145568)

Will be used in inductor.

Pull Request resolved: pytorch#145568
Approved by: https://github.com/malfet, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@jansel jansel Awaiting requested review from jansel

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged module: inductor module: mps Related to Apple Metal Performance Shaders framework topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dcci @pytorchmergebot @Skylion007 @malfet