Make sure not using cpp wrapper when setting nvtx training annotation #145538
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145538
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 98 PendingAs of commit 5a600be with merge base 354fe48 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
desertfire
left a comment
desertfire
left a comment
There was a problem hiding this comment.
You must have tested this locally with something. Please add your unit test to https://github.com/pytorch/pytorch/blob/main/test/inductor/test_gpu_cpp_wrapper.py .
exclamaforte
force-pushed
the
exclamaforte/cpp-wrapper-training-annotation
branch
2 times, most recently
from
06b940e to
112b97d
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
exclamaforte
force-pushed
the
exclamaforte/cpp-wrapper-training-annotation
branch
from
112b97d to
5a600be
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -f "failure seems unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
## Summary: Dynamo now works with config fuzzer. For BE week, we also found and fixed 5 different bugs (in inductor): - pytorch#145426 - pytorch#145523 - pytorch#145527 - pytorch#145532 - pytorch#145538 ## Test Plan: New Dynamo Unit tests Pull Request resolved: pytorch#145565 Approved by: https://github.com/masnesral
github-actions
bot
deleted the
exclamaforte/cpp-wrapper-training-annotation
branch
3 participants
Longer term would be good to add as a feature to cpp_wrapper, but this makes sure it doesn't fail on main.
Not sure if this needs a test because it's not meant to compose, but will add one if necessary.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov