Skip to content

Conversation

@exclamaforte
Copy link
Contributor

@exclamaforte exclamaforte commented Jan 23, 2025

Running torch compile with these options causes an error, because the benchmark code isn't generated but is still called.

options={'profile_bandwidth_output': 'foo', 'benchmark_harness': False}

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145532

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 2e82ff3 with merge base 354fe48 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 21:38 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 21:38 Inactive
@exclamaforte exclamaforte force-pushed the exclamaforte/benchmark-harness branch from 846d63d to df44030 Compare January 27, 2025 19:59
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 20:31 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 20:31 Inactive
@exclamaforte exclamaforte force-pushed the exclamaforte/benchmark-harness branch from df44030 to 2e82ff3 Compare January 29, 2025 19:45
@exclamaforte
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

carmocca pushed a commit to carmocca/pytorch that referenced this pull request Feb 12, 2025
## Summary:
Dynamo now works with config fuzzer.

For BE week, we also found and fixed 5 different bugs (in inductor):
- pytorch#145426
- pytorch#145523
- pytorch#145527
- pytorch#145532
- pytorch#145538

## Test Plan:
New Dynamo Unit tests

Pull Request resolved: pytorch#145565
Approved by: https://github.com/masnesral
@github-actions github-actions bot deleted the exclamaforte/benchmark-harness branch March 1, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants