fix intermediate debug information with cpp_wrapper #145527

exclamaforte · 2025-01-23T20:53:07Z

Summary: before fix, code like:

    aoti_torch_print_tensor_handle(buf0, "after_launch - triton_poi_fused_randn_0 - buf0");
    aoti_torch_print_tensor_handle(buf1, "after_launch - triton_poi_fused_randn_0 - buf1");
    printf("[  after_launch - triton_poi_fused_randn_0 - 0: %ld  ]", 0); printf("
");
    printf("[  after_launch - triton_poi_fused_randn_0 - 1228800L: %ld  ]", 1228800L); printf("
");

was generated, which is a syntax error.

Test Plan:
New unit test.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

pytorch-bot · 2025-01-23T20:53:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145527

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 65e751f with merge base 49082f9 ():

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

trunk / linux-focal-rocm6.3-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4) (gh) (#146646)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

exclamaforte · 2025-01-27T17:43:02Z

@pytorchbot merge

pytorchmergebot · 2025-01-27T17:44:52Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-27T17:45:13Z

Merge failed

Reason: 30 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

exclamaforte · 2025-01-28T03:25:42Z

@pytorchbot merge

pytorchmergebot · 2025-01-28T03:27:39Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

exclamaforte · 2025-01-29T19:43:54Z

@pytorchbot merge

pytorchmergebot · 2025-01-29T19:45:45Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-29T20:07:14Z

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

exclamaforte · 2025-01-30T17:58:05Z

@pytorchbot merge

pytorchmergebot · 2025-01-30T17:59:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-30T18:05:25Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / Test tools / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:

exclamaforte · 2025-02-07T00:30:11Z

@pytorchbot merge

pytorchmergebot · 2025-02-07T00:32:02Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-02-07T06:30:34Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

exclamaforte · 2025-02-10T22:22:23Z

@pytorchbot merge

pytorchmergebot · 2025-02-10T22:24:01Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

## Summary: Dynamo now works with config fuzzer. For BE week, we also found and fixed 5 different bugs (in inductor): - pytorch#145426 - pytorch#145523 - pytorch#145527 - pytorch#145532 - pytorch#145538 ## Test Plan: New Dynamo Unit tests Pull Request resolved: pytorch#145565 Approved by: https://github.com/masnesral

exclamaforte requested a review from desertfire January 23, 2025 20:53

pytorch-bot bot added ciflow/inductor module: inductor labels Jan 23, 2025

exclamaforte added the topic: bug fixes topic category label Jan 23, 2025

pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 21:23 Inactive

exclamaforte mentioned this pull request Jan 24, 2025

Refactor fuzzer and add support for Dynamo #145565

Closed

desertfire approved these changes Jan 24, 2025

View reviewed changes

exclamaforte added the release notes: inductor label Jan 24, 2025

exclamaforte force-pushed the exclamaforte/cpp-wrapper-debug branch from 31de661 to c2ed20a Compare January 24, 2025 19:02

pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 19:34 Inactive

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 27, 2025

pytorchmergebot added the merging label Jan 27, 2025

pytorchmergebot removed the merging label Jan 27, 2025

pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 18:12 Inactive

exclamaforte force-pushed the exclamaforte/cpp-wrapper-debug branch from c2ed20a to 37c9615 Compare January 28, 2025 03:25

pytorchmergebot added the merging label Jan 28, 2025

pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 03:55 Inactive

pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 03:56 Inactive

pytorchmergebot removed the merging label Jan 28, 2025

exclamaforte force-pushed the exclamaforte/cpp-wrapper-debug branch from ed2e39c to dba5d12 Compare January 29, 2025 19:43

pytorchmergebot added the merging label Jan 29, 2025

pytorchmergebot removed the merging label Jan 29, 2025

exclamaforte force-pushed the exclamaforte/cpp-wrapper-debug branch 2 times, most recently from 0077cba to 436f885 Compare January 30, 2025 17:57

pytorchmergebot added the merging label Jan 30, 2025

pytorchmergebot removed the merging label Jan 30, 2025

fix intermediate debug information with cpp_wrapper

65e751f

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:

exclamaforte force-pushed the exclamaforte/cpp-wrapper-debug branch from 436f885 to 65e751f Compare February 7, 2025 00:30

pytorchmergebot added the merging label Feb 7, 2025

pytorchmergebot added the Merged label Feb 10, 2025

pytorchmergebot closed this in bab35eb Feb 10, 2025

pytorchmergebot removed the merging label Feb 10, 2025

github-actions bot deleted the exclamaforte/cpp-wrapper-debug branch March 13, 2025 02:09

fix intermediate debug information with cpp_wrapper #145527

fix intermediate debug information with cpp_wrapper #145527

Uh oh!

Conversation

exclamaforte commented Jan 23, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145527

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

exclamaforte commented Jan 27, 2025

Uh oh!

pytorchmergebot commented Jan 27, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 27, 2025

Merge failed

Uh oh!

exclamaforte commented Jan 28, 2025

Uh oh!

pytorchmergebot commented Jan 28, 2025

Merge started

Uh oh!

exclamaforte commented Jan 29, 2025

Uh oh!

pytorchmergebot commented Jan 29, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 29, 2025

Merge failed

Uh oh!

exclamaforte commented Jan 30, 2025

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge failed

Uh oh!

exclamaforte commented Feb 7, 2025

Uh oh!

pytorchmergebot commented Feb 7, 2025

Merge started

Uh oh!

pytorchmergebot commented Feb 7, 2025

Uh oh!

exclamaforte commented Feb 10, 2025

Uh oh!

pytorchmergebot commented Feb 10, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

exclamaforte commented Jan 23, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jan 23, 2025 •

edited

Loading