Skip to content

Missing autorelease in lstm_mps caused a ton of leaked memory #145503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jhavukainen wants to merge 1 commit into from
Closed

Missing autorelease in lstm_mps caused a ton of leaked memory #145503

jhavukainen wants to merge 1 commit into from

Conversation

@jhavukainen
Copy link
Collaborator

@jhavukainen jhavukainen commented Jan 23, 2025 •
edited by malfet
Loading

The dictionary held onto the new MPSGraphTensorData objects and MPSNDArrays. Regression caused by #95137

Fixes #145374

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145503

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 32 Pending

As of commit 833f58c with merge base 3a8d378 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jan 23, 2025
@jhavukainen jhavukainen mentioned this pull request Jan 23, 2025
Open
@Skylion007
Copy link
Collaborator

Skylion007 commented Jan 23, 2025

This is a good backport candidate

@malfet malfet added this to the 2.6.1 milestone Jan 23, 2025
@malfet
Copy link
Contributor

malfet commented Jan 23, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 23, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the dev/joona/lstm_leak branch February 23, 2025 02:10
Copilot AI mentioned this pull request Oct 22, 2025
Draft
@jmpnop jmpnop mentioned this pull request Nov 17, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category

Projects

None yet

Milestone

2.6.1

Development

Successfully merging this pull request may close these issues.

Memory Leak in MPS Backend During LSTM Iterations (Out of Memory Error)

6 participants

@jhavukainen @Skylion007 @malfet @pytorchmergebot @pytorchbot