Skip to content

Fix aot inductor intermediate debug printing #145426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
exclamaforte wants to merge 0 commits into from
Closed

Fix aot inductor intermediate debug printing #145426

exclamaforte wants to merge 0 commits into from

Conversation

@exclamaforte
Copy link
Contributor

@exclamaforte exclamaforte commented Jan 22, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145426

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 3667402 with merge base 49082f9 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 00:31 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 00:31 Inactive
desertfire
desertfire reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@desertfire desertfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this failing a specific test? Otherwise, adding another test?

@exclamaforte exclamaforte force-pushed the exclamaforte/aot-inductor-debug branch from 3ff3873 to 63ccf25 Compare January 23, 2025 18:57
@exclamaforte exclamaforte force-pushed the exclamaforte/aot-inductor-debug branch from 63ccf25 to 1167807 Compare January 23, 2025 19:02
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 19:31 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 19:31 Inactive
@exclamaforte exclamaforte mentioned this pull request Jan 24, 2025
Closed
@exclamaforte exclamaforte force-pushed the exclamaforte/aot-inductor-debug branch 2 times, most recently from e2bba04 to 47fdfcd Compare January 24, 2025 18:56
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 19:27 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 19:27 Inactive
@exclamaforte exclamaforte force-pushed the exclamaforte/aot-inductor-debug branch from 47fdfcd to 3667402 Compare February 7, 2025 00:28
@exclamaforte
Copy link
Contributor Author

exclamaforte commented Feb 7, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 7, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 7, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 7, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, lf.windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@exclamaforte
Copy link
Contributor Author

exclamaforte commented Feb 7, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 7, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, lf.windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 7, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@exclamaforte
Copy link
Contributor Author

exclamaforte commented Feb 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, lf.windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@exclamaforte
Copy link
Contributor Author

exclamaforte commented Feb 11, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 11, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, lf.windows.4xlarge.nonephemeral), trunk / linux-focal-rocm6.3-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 11, 2025

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch merge --squash __pull-request-145426__init__ returned non-zero exit code 1

Auto-merging test/inductor/test_gpu_cpp_wrapper.py
CONFLICT (content): Merge conflict in test/inductor/test_gpu_cpp_wrapper.py
Auto-merging torch/_inductor/codegen/debug_utils.py
Squash commit -- not updating HEAD
Automatic merge failed; fix conflicts and then commit the result.
Details for Dev Infra team Raised by workflow job

carmocca pushed a commit to carmocca/pytorch that referenced this pull request Feb 12, 2025
@exclamaforte @pytorchmergebot
Refactor fuzzer and add support for Dynamo (pytorch#145565)
f16ce3c 
## Summary:
Dynamo now works with config fuzzer.

For BE week, we also found and fixed 5 different bugs (in inductor):
- pytorch#145426
- pytorch#145523
- pytorch#145527
- pytorch#145532
- pytorch#145538

## Test Plan:
New Dynamo Unit tests

Pull Request resolved: pytorch#145565
Approved by: https://github.com/masnesral
@exclamaforte exclamaforte force-pushed the exclamaforte/aot-inductor-debug branch from 3667402 to 7ae0e0b Compare February 27, 2025 22:21
@github-actions github-actions bot deleted the exclamaforte/aot-inductor-debug branch March 30, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

@YUNQIUGUO YUNQIUGUO Awaiting requested review from YUNQIUGUO

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: aotinductor aot inductor module: inductor release notes: inductor topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aot inductor intermediate tensor debug printing (setting 2) not working

3 participants

@exclamaforte @pytorchmergebot @desertfire