Made partitioning more(?) deterministic #145024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145024
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 11 New FailuresAs of commit e46c096 with merge base 17a6d4b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
This PR needs a
|
[ghstack-poisoned]
[ghstack-poisoned]
ezyang
approved these changes
Jan 17, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
eellison
reviewed
Jan 23, 2025
Contributor
eellison
left a comment
eellison
left a comment
There was a problem hiding this comment.
i think we can just opt in torch/_functorch/partitioners to the OrderedSet linter as well..
masnesral
added a commit
that referenced
this pull request
Jan 31, 2025
Copied from #145024, but made _all_ sets OrderedSets and fixed mypy complaints. Note that this change does not fix the non-determinism we're seeing in the internal model. But let's at least eliminate this potential source of non-determinism before investigating any changes to the mincut approach? [ghstack-poisoned]
masnesral
added a commit
that referenced
this pull request
Jan 31, 2025
Copied from #145024, but made _all_ sets OrderedSets and fixed mypy complaints. Note that this change does not fix the non-determinism we're seeing in the internal model. But let's at least eliminate this potential source of non-determinism before investigating any changes to the mincut approach? [ghstack-poisoned]
masnesral
added a commit
that referenced
this pull request
Jan 31, 2025
Copied from #145024, but made _all_ sets OrderedSets and fixed mypy complaints. Note that this change does not fix the non-determinism we're seeing in the internal model. But let's at least eliminate this potential source of non-determinism before investigating any changes to the mincut approach? [ghstack-poisoned]
masnesral
added a commit
that referenced
this pull request
Jan 31, 2025
Copied from #145024, but made _all_ sets OrderedSets and fixed mypy complaints. Note that this change does not fix the non-determinism we're seeing in the internal model. But let's at least eliminate this potential source of non-determinism before investigating any changes to the mincut approach? [ghstack-poisoned]
masnesral
added a commit
that referenced
this pull request
Feb 1, 2025
Copied from #145024, but made _all_ sets OrderedSets and fixed mypy complaints. Note that this change does not fix the non-determinism we're seeing in the internal model. But let's at least eliminate this potential source of non-determinism before investigating any changes to the mincut approach? [ghstack-poisoned]
masnesral
added a commit
that referenced
this pull request
Feb 4, 2025
Copied from #145024, but made _all_ sets OrderedSets and fixed mypy complaints. Note that this change does not fix the non-determinism we're seeing in the internal model. But let's at least eliminate this potential source of non-determinism before investigating any changes to the mincut approach? [ghstack-poisoned]
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):