upgrade to sccache 0.9.1 - dealing with nvcc -E correctly#145012
upgrade to sccache 0.9.1 - dealing with nvcc -E correctly#145012
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145012
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 9863b98 with merge base 573fc42 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
left a comment
There was a problem hiding this comment.
SGTM, do you want to undo -E workarounds right away? Or in the followup PR
Will do in follow up PR to decouple |
|
@pytorchmergebot -h rebase |
PyTorchBot HelpMergeRevertRebaseLabelDr CIcherry-pickCloseusage: @pytorchbot close Close a PR [Can be used on issues] |
|
@pytorchmergebot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
31db637 to
9863b98
Compare
|
@pytorchmergebot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: windows-binary-wheel / wheel-py3_10-xpu-test, inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_timm, 1, 2, linux.8xlarge.amx), inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
sccache 0.9.1 should be dealing with
nvcc -Ecorrectlysee mozilla/sccache#2300
If this works as expected, we can get rid of this code:
https://github.com/pytorch/pytorch/pull/142813/files
cc @malfet