Skip to content

Conversation

@jianan-gu
Copy link
Contributor

@jianan-gu jianan-gu commented Jan 16, 2025

This PR extends and refines all rest UTs for CPU and more devices in test/inductor/test_flex_attention.py and test/inductor/test_flex_decoding.py, as a follow-up to #141453

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

@jianan-gu jianan-gu requested a review from mruberry as a code owner January 16, 2025 09:05
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144953

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit bfb1834 with merge base 01f226b (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jianan-gu jianan-gu marked this pull request as draft January 16, 2025 09:05
@chunyuan-w chunyuan-w added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jan 16, 2025
@chunyuan-w chunyuan-w added the topic: not user facing topic category label Jan 17, 2025
@jianan-gu jianan-gu changed the title [Draft][Inductor UT] CPU FlexAttention UT refactors [Inductor UT] CPU FlexAttention UT refactors Jan 20, 2025
@jianan-gu jianan-gu marked this pull request as ready for review January 20, 2025 09:41
@jianan-gu jianan-gu changed the title [Inductor UT] CPU FlexAttention UT refactors [Inductor UT] Refactor FlexAttention UT and add CPU tests Jan 20, 2025
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 22, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2025

To add the ciflow label ciflow/inductor please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Apr 14, 2025
@yanbing-j yanbing-j added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor labels Apr 14, 2025
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor labels Apr 15, 2025
@leslie-fang-intel leslie-fang-intel added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Apr 15, 2025
@jianan-gu
Copy link
Contributor Author

@pytorchbot merge

@chunyuan-w
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

timocafe pushed a commit to timocafe/pytorch that referenced this pull request Apr 16, 2025
…4953)

This PR extends and refines all rest UTs for CPU and more devices in `test/inductor/test_flex_attention.py`  and `test/inductor/test_flex_decoding.py`, as a follow-up to pytorch#141453

Pull Request resolved: pytorch#144953
Approved by: https://github.com/drisspg
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
…4953)

This PR extends and refines all rest UTs for CPU and more devices in `test/inductor/test_flex_attention.py`  and `test/inductor/test_flex_decoding.py`, as a follow-up to pytorch#141453

Pull Request resolved: pytorch#144953
Approved by: https://github.com/drisspg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor no-stale open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants