Skip to content

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Jan 8, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144425

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c901ad5 with merge base 3068ce0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki mikaylagawarecki added release notes: nn release notes category topic: docs topic category labels Jan 8, 2025
mikaylagawarecki added a commit that referenced this pull request Jan 8, 2025
ghstack-source-id: 2ffe9b8
Pull Request resolved: #144425
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review January 9, 2025 15:31
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator

albanD commented Jan 9, 2025

@pytorchbot cherry-pick --onto release/2.6 -c docs

@pytorchbot
Copy link
Collaborator

Cherry picking #144425

The cherry pick PR is at #144482 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

kit1980 pushed a commit that referenced this pull request Jan 9, 2025
Link to transformer tutorial in transformer docs (#144425)

<img width="1045" alt="Screenshot 2025-01-08 at 4 50 20 PM" src="https://github.com/user-attachments/assets/05adfecb-8a23-4c48-9a2c-50c5b3f886b0" />

Pull Request resolved: #144425
Approved by: https://github.com/albanD

(cherry picked from commit b8f3831)

Co-authored-by: Mikayla Gawarecki <[email protected]>
@github-actions github-actions bot deleted the gh/mikaylagawarecki/303/head branch February 12, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: docs topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants