Skip to content

[EZ] Update sympy to 1.13.3 #143908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

[EZ] Update sympy to 1.13.3 #143908

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Dec 27, 2024

And remove python>=3.9 check as it currently covers all supported python versions

Fixes #143907

@malfet
[EZ] Update sympy to 1.13.3
ffb5012 
And remove python>=3.9 check as it currently covers all supported python versions
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143908

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit ffb5012 with merge base a20765a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 27, 2024
@malfet malfet requested a review from a team December 27, 2024 14:56
@Skylion007
Copy link
Collaborator

Skylion007 commented Dec 27, 2024

Also probably a good backport candidate for 2.6

@malfet
Copy link
Contributor Author

malfet commented Dec 27, 2024

Also probably a good backport candidate for 2.6

Hmm, let me check meta information, I thought that requirements.txt are just for local development, while PyPI wheels has an unpinned dependency.

@malfet
Copy link
Contributor Author

malfet commented Dec 27, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 27, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 27, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Dec 27, 2024

@pytorchbot merge -f "I trust ROCM builds will work"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 27, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 27, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@evan0greenup
Copy link

evan0greenup commented Dec 28, 2024

@malfet , is it possible to add wildcard in sympy version like 1.13.* or >=1.13, because in the future when sympy release new version, this issue will arise again. And it is rare for sympy to have break change.

galexite pushed a commit to graphcore/pytorch-fork that referenced this pull request Dec 30, 2024
@malfet @galexite
[EZ] Update sympy to 1.13.3 (pytorch#143908)
ce459c9 
And remove python>=3.9 check as it currently covers all supported python versions

Fixes pytorch#143907

Pull Request resolved: pytorch#143908
Approved by: https://github.com/Skylion007, https://github.com/huydhn
@jeongseok-meta jeongseok-meta mentioned this pull request Jan 22, 2025
Closed
@github-actions github-actions bot deleted the malfet-patch-14 branch January 28, 2025 02:04
@fffrog fffrog mentioned this pull request Feb 14, 2025
Closed
fffrog added a commit that referenced this pull request Feb 14, 2025
@fffrog
Unify all sympy versions to avoid conflicts within PyTorch
7d425fa 
As the title stated.

**Previous PR:**
#143908

**ISSUE Related:**
#147144

ghstack-source-id: b1918e6
Pull Request resolved: #147197
pytorchmergebot pushed a commit that referenced this pull request Feb 16, 2025
@fffrog
Unify all sympy versions to avoid conflicts within PyTorch
20b9c92 
As the title stated.

**Previous PR:**
#143908

**ISSUE Related:**
#147144

ghstack-source-id: cf58b37
Pull Request resolved: #147197
fffrog added a commit that referenced this pull request Feb 17, 2025
@fffrog
Unify all sympy versions to avoid conflicts within PyTorch
cfc35f9 
As the title stated.

There are some tiny diffrences between 1.13.1 and 1.13.3:
1.13.1:
https://github.com/sympy/sympy/blob/2e489cf4b1438ae134ba98a44a80cc9add1306b0/sympy/core/numbers.py#L1591

1.13.3:
https://github.com/sympy/sympy/blob/b4ce69ad5d40e4e545614b6c76ca9b0be0b98f0b/sympy/core/numbers.py#L1591

**Previous PR:**
#143908

**ISSUE Related:**
#147144

ghstack-source-id: 1449218
Pull Request resolved: #147197
fffrog added a commit that referenced this pull request Feb 18, 2025
@fffrog
Unify all sympy versions to avoid conflicts within PyTorch
ab15351 
As the title stated.

There are some tiny diffrences between 1.13.1 and 1.13.3:
1.13.1:
https://github.com/sympy/sympy/blob/2e489cf4b1438ae134ba98a44a80cc9add1306b0/sympy/core/numbers.py#L1591

1.13.3:
https://github.com/sympy/sympy/blob/b4ce69ad5d40e4e545614b6c76ca9b0be0b98f0b/sympy/core/numbers.py#L1591

**Previous PR:**
#143908

**ISSUE Related:**
#147144

ghstack-source-id: 004a95d
Pull Request resolved: #147197
pytorchmergebot pushed a commit that referenced this pull request Feb 18, 2025
@fffrog @pytorchmergebot
Unify all sympy versions to avoid conflicts within PyTorch (#147197)
b10ba0a 
As the title stated.

There are some tiny diffrences between 1.13.1 and 1.13.3:
1.13.1:
https://github.com/sympy/sympy/blob/2e489cf4b1438ae134ba98a44a80cc9add1306b0/sympy/core/numbers.py#L1591

1.13.3:
https://github.com/sympy/sympy/blob/b4ce69ad5d40e4e545614b6c76ca9b0be0b98f0b/sympy/core/numbers.py#L1591

**Previous PR:**
#143908

**ISSUE Related:**
#147144
Pull Request resolved: #147197
Approved by: https://github.com/malfet
@tardigradus tardigradus mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update sympy version in requirement.txt

6 participants

@malfet @Skylion007 @pytorchmergebot @evan0greenup @huydhn