Skip to content

[inductor] fix the adaptive_avg_pool on processing int64 #143802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shaoyuyoung wants to merge 3 commits into from
Closed

[inductor] fix the adaptive_avg_pool on processing int64 #143802

shaoyuyoung wants to merge 3 commits into from

Conversation

@shaoyuyoung
Copy link
Contributor

@shaoyuyoung shaoyuyoung commented Dec 24, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143802

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f17c698 with merge base 27b0d41 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@shaoyuyoung shaoyuyoung changed the title fix the adaptive_avg_pool inductor] fix the adaptive_avg_pool on processing int64 Dec 24, 2024
@shaoyuyoung shaoyuyoung changed the title inductor] fix the adaptive_avg_pool on processing int64 [inductor] fix the adaptive_avg_pool on processing int64 Dec 24, 2024
@shaoyuyoung
Copy link
Contributor Author

shaoyuyoung commented Dec 24, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 24, 2024
@shaoyuyoung
Copy link
Contributor Author

shaoyuyoung commented Dec 24, 2024

It seems that I don't have permission to request a review.
(I am very sorry that I tried the CI process of pytorch for the first time.)

jansel
jansel requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, but otherwise looks good. I approved CI for you.

@shaoyuyoung
Copy link
Contributor Author

shaoyuyoung commented Dec 25, 2024

Hi, @jansel .
I really appreciate that you can still help me review and point out my mistakes during the holiday. I have updated.
Merry Christmas (Eve)!

@shaoyuyoung shaoyuyoung requested a review from jansel December 25, 2024 01:16
@jansel
Copy link
Contributor

jansel commented Dec 25, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 25, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 25, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[inductor] AdaptiveAvgPool behaves differently on eager and inductor when meeting internal int64 dtypes

4 participants

@shaoyuyoung @jansel @pytorchmergebot @pytorchbot