[Inductor][CPU] disable bernoulli_p decomposition #143460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143460
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 939637b with merge base e890d67 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
Should we just remove this decomp entirely and keep the version for fallback_random=False? |
leslie-fang-intel
approved these changes
Dec 19, 2024
Collaborator
Author
|
Yes. I have updated the code. |
jgong5
approved these changes
Dec 19, 2024
jansel
approved these changes
Dec 19, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fix #142853
fallback_random=Trueshould cause RNG to match between compile/eager (by having compile fall back to eager for RNG ops), but thebernoulli_pdecompose function is not fully consistent with the eager CPU implementation.We remove the decomp and keep the version for
fallback_random=False.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov