Add a language option for symbolic shape guards #143164
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143164
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ec7982d with merge base 19c3ba4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
release notes: fx
|
I guess some bits of this don't make sense without the next PR? |
|
Yes, need the other PR in the stack for it to make sense. Previously I was going to return all of python, C++, verbose and use whatever was necessary. However, this resulted in a compile time regression because we were now generating C++ in addition to python when C++ was not necessary. This PR generates python and verbose or C++ and verbose. The issue I'm facing now is that for guard export we need python.
I guess the solution that I should go for is to do cc @amjames |
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
ok fine. You might consider naming verbose "verbose_python" as that's more accurate.
Pull Request resolved: #139899 Approved by: https://github.com/anijain2305, https://github.com/albanD, https://github.com/jansel ghstack dependencies: #143385, #143164
Stack from ghstack (oldest at bottom):
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames