Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Dec 13, 2024

We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271
Hence constraint is no longer needed.
This stack enabled torch.compile for Python 3.13 : #141264

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143162

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 559e3f4 with merge base 9f5ebf3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 13, 2024
@atalman atalman mentioned this pull request Dec 13, 2024
37 tasks
@atalman atalman changed the title Linux Wheels: Remove triton dependency python < 3.13 constrain Linux Wheels: Remove triton dependency python < 3.13 constraint Dec 13, 2024
@atalman
Copy link
Contributor Author

atalman commented Dec 13, 2024

@pytorchmergebot merge -f "lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author

atalman commented Dec 13, 2024

@pytorchbot cherry-pick --onto release/2.6 -c critical

pytorchbot pushed a commit that referenced this pull request Dec 13, 2024
@pytorchbot
Copy link
Collaborator

Cherry picking #143162

The cherry pick PR is at #143199 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

malfet pushed a commit that referenced this pull request Dec 13, 2024
)

Linux Wheels: Remove triton dependency python < 3.13 constraint (#143162)

We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271
Hence constraint is no longer needed.
This stack enabled torch.compile for Python 3.13 : #141264
Pull Request resolved: #143162
Approved by: https://github.com/kit1980

(cherry picked from commit 04bb82f)

Co-authored-by: Andrey Talman <[email protected]>
pytorchmergebot pushed a commit that referenced this pull request Dec 14, 2024
pytorchbot pushed a commit that referenced this pull request Dec 14, 2024
Follow up after #143162
Include triton only for 3.13 packages not 3.13t
Pull Request resolved: #143218
Approved by: https://github.com/kit1980

(cherry picked from commit 3bfdf6f)
atalman pushed a commit that referenced this pull request Dec 16, 2024
atalman added a commit that referenced this pull request Dec 16, 2024
Exclude py 31.3t triton package from PyTorch 3.13t wheel (#143218)

Follow up after #143162
Include triton only for 3.13 packages not 3.13t
Pull Request resolved: #143218
Approved by: https://github.com/kit1980

(cherry picked from commit 3bfdf6f)

Co-authored-by: atalman <[email protected]>
@github-actions github-actions bot deleted the atalman-patch-4 branch January 14, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants