Revert "handle sympy.oo in bitwise_and/or value_ranges (#141522)" and "[dynamo] add SymNode bitwise and/or (#138777)" #142842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142842
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 174abfc with merge base dd2d0c6 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: cpu
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
Contributor
Author
|
@williamwen42 I am interested in figuring out if we can avoid landing this directly and instead try to just config gate bitwise and/or |
Contributor
Author
|
@ezyang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ezyang
added a commit
that referenced
this pull request
Dec 11, 2024
Contributor
Author
|
@ezyang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| "OpaqueUnaryFn_atan": math.atan, | ||
| "OpaqueUnaryFn_sqrt": math.sqrt, | ||
| "BitwiseFn_bitwise_and": operator.and_, | ||
| "BitwiseFn_bitwise_or": operator.or_, |
Member
There was a problem hiding this comment.
Do we need to add these back in, since #140597 removed them? Also, BitwiseFn_bitwise_and/or are no longer defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reverts commit 6fa4356.
This reverts commit ee7eaad.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @SherlockNoMad @EikanWang @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames
Differential Revision: D67072558