[Dynamo] Stop importing transformers #142502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This import was free because transformers should already have been imported by this time. Test Plan: - CI [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142502
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 684c9c3 with merge base 5d3bc63 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
StrongerXi
approved these changes
Dec 10, 2024
yanboliang
approved these changes
Dec 10, 2024
mlazos
approved these changes
Dec 11, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 11, 2024
PyTorch's minimum version is 3.9, so we can now use ast.unparse. Test Plan: - wait for tests Pull Request resolved: #142503 Approved by: https://github.com/StrongerXi, https://github.com/yanboliang, https://github.com/mlazos ghstack dependencies: #142502
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Fixes #127738 Fixes #127755 In the discussion in #127738 we determined that this is not fixable, so we're just going to skip the test. Test Plan: - tests Pull Request resolved: #142508 Approved by: https://github.com/StrongerXi, https://github.com/yanboliang, https://github.com/mlazos ghstack dependencies: #142502, #142503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This import was free because transformers should already have been
imported by this time.
Test Plan:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames