Fix ARM bfloat16 fmsub & improve vec_test_all_types coverage #142499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was very broken and untested. Now it is tested, and vec_test_all_types is passing internally as well. Differential Revision: [D67036894](https://our.internmc.facebook.com/intern/diff/D67036894/) [ghstack-poisoned]
pytorch-bot
bot
added
the
module: cpu
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142499
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 15dcee2 with merge base 3291b0a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Dec 10, 2024
This function was very broken and untested. Now it is tested, and vec_test_all_types is passing internally as well. Differential Revision: [D67036894](https://our.internmc.facebook.com/intern/diff/D67036894/) ghstack-source-id: 257473097 Pull Request resolved: #142499
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67036894 |
malfet
approved these changes
Dec 10, 2024
malfet
added
release notes: build
Contributor
|
@pytorchbot merge |
Contributor
|
For person who would be writing release notes - |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This function was very broken and untested. Now it is tested, and vec_test_all_types is passing internally as well.
Differential Revision: D67036894
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10