Fix timeout check workflow lint job #142476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142476
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9f82330 with merge base d3d1a78 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
changed the title
wdvr
approved these changes
Dec 10, 2024
Contributor
There was a problem hiding this comment.
why is the generated file changed, but not the source file? Did we forget to generate on a previous commit?
Contributor
Author
Contributor
Author
|
@pytorchbot merge -f 'Lint jobs have passed' |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
reviewed
Dec 10, 2024
Comment on lines
+210
to
+211
| PYTHONPATH=$(pwd) pytest tools/test/test_*.py | ||
| PYTHONPATH=$(pwd) pytest .github/scripts/test_*.py |
Contributor
There was a problem hiding this comment.
Isn't this only setting they PYTHONPATH env var, resulting in no test files being executed or discovered?
Contributor
Author
There was a problem hiding this comment.
Good catch! The test works but one test there is not working with pytest https://github.com/pytorch/pytorch/actions/runs/12264094674/job/34217191327?pr=142476#step:14:135, so let me fix it
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Dec 11, 2024
Fixes pytorch#142485 The workflow check lint job timed out in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/12261226178/job/34207762939, and here was what happened: 1. pytorch#142294 landed yesterday to build ROCm on 3.13, but the PR had a landrace with pytorch#142282 in the generated workflow file 2. The trunk lint check caught that in https://github.com/pytorch/pytorch/blob/main/.github/scripts/report_git_status.sh#L2 3. However, the script also attempted to print the difference with `git diff .github/workflows`. This command was the one that stuck because `git diff` uses page by default and requires a prompt to display the next page ¯\_(ツ)_/¯ It took so long to debug this because a timeout Nova GHA doesn't print any progress. I'll create an issue for this. Bonus: I also fix the broken print from test tool lint job that confuses GitHub https://github.com/pytorch/pytorch/actions/runs/12261226178 with an annotation failure `Credentials could not be loaded, please check your action inputs` Pull Request resolved: pytorch#142476 Approved by: https://github.com/wdvr
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 12, 2024
A follow-up from #142476 (comment) where some tests are not discovered correctly by pytest ### Testing https://github.com/pytorch/pytorch/actions/runs/12287448581/job/34289531307?pr=143052#step:14:162 shows the correct number of tests now Pull Request resolved: #143052 Approved by: https://github.com/ZainRizvi
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
Fixes pytorch#142485 The workflow check lint job timed out in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/12261226178/job/34207762939, and here was what happened: 1. pytorch#142294 landed yesterday to build ROCm on 3.13, but the PR had a landrace with pytorch#142282 in the generated workflow file 2. The trunk lint check caught that in https://github.com/pytorch/pytorch/blob/main/.github/scripts/report_git_status.sh#L2 3. However, the script also attempted to print the difference with `git diff .github/workflows`. This command was the one that stuck because `git diff` uses page by default and requires a prompt to display the next page ¯\_(ツ)_/¯ It took so long to debug this because a timeout Nova GHA doesn't print any progress. I'll create an issue for this. Bonus: I also fix the broken print from test tool lint job that confuses GitHub https://github.com/pytorch/pytorch/actions/runs/12261226178 with an annotation failure `Credentials could not be loaded, please check your action inputs` Pull Request resolved: pytorch#142476 Approved by: https://github.com/wdvr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142485
The workflow check lint job timed out in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/12261226178/job/34207762939, and here was what happened:
git diff .github/workflows. This command was the one that stuck becausegit diffuses page by default and requires a prompt to display the next page ¯_(ツ)_/¯It took so long to debug this because a timeout Nova GHA doesn't print any progress. I'll create an issue for this.
Bonus:
I also fix the broken print from test tool lint job that confuses GitHub https://github.com/pytorch/pytorch/actions/runs/12261226178 with an annotation failure
Credentials could not be loaded, please check your action inputs