Fix test_indexing on MacOS #142440
Fix test_indexing on MacOS #142440
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142440
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 158c526 with merge base ec746f7 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: inductor
topic: not user facing
test/inductor/test_indexing.py
Outdated
| expr = Mod(x - 1, 2) | ||
| self.assertExpectedInline(pexpr(expr), """((-1) + x) % 2""") | ||
| self.assertExpectedInline(cexpr(expr), """((-1L) + x) % 2L""") | ||
| self.assertExpectedInline(cexpr(expr), f"""((-1{LONG_SUFFIX}) + x) % 2{LONG_SUFFIX}""") |
There was a problem hiding this comment.
Hm, according to https://github.com/pytorch/pytorch/actions/runs/12243930945/job/34154950933 the value is somehow is ((-1LL) + x) % 2, not ((-1LL) + x) % 2LL
There was a problem hiding this comment.
I run test locally and it passed with LL (which makes sense)
|
@pytorchbot merge -f "Local lint + tests(and CI ones as well) are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Where int64_t is long long rather than long This fixes test regression introduced by pytorch/pytorch#140597 that went undetected due to pytorch/pytorch#142206 ghstack-source-id: e7e260c Pull Request resolved: pytorch/pytorch#142440
Stack from ghstack (oldest at bottom):
Where int64_t is long long rather than long
This fixes test regression introduced by #140597 that went undetected due to #142206
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov