Skip to content

[cpu/aarch64] fix compilation for Vec:bf16 (128bit) #142370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aditew01 wants to merge 1 commit into from
Closed

[cpu/aarch64] fix compilation for Vec:bf16 (128bit) #142370

aditew01 wants to merge 1 commit into from

Conversation

@aditew01
Copy link
Collaborator

@aditew01 aditew01 commented Dec 9, 2024 •
edited by pytorch-bot bot
Loading

Fix typo causing compilation error on aarch64 architecture with BF16 support. (#139090)

tag: @swolchok

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @malfet @snadampal @milpuz01

@aditew01 aditew01 added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Dec 9, 2024
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 9, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142370

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bdcf609 with merge base f14ce3a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@aditew01 aditew01 requested a review from swolchok December 9, 2024 13:56
malfet
malfet approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@malfet malfet added release notes: build release notes category topic: bug fixes topic category labels Dec 9, 2024
@malfet
Copy link
Contributor

malfet commented Dec 9, 2024

@pytorchbot merge -f "This is clearly a correct fix"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@swolchok
Copy link
Contributor

swolchok commented Dec 10, 2024

sorry about the mess. I wrote #142499 to add the missing test coverage (and fully unbreak vec_test_all_types while I was at it)

@swolchok swolchok mentioned this pull request Dec 10, 2024
Open
@github-actions github-actions bot deleted the aditew01/vec128_vec_neon_fix branch January 11, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

Merged module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 module: cpu CPU specific problem (e.g., perf, algorithm) open source release notes: build release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aditew01 @malfet @pytorchmergebot @swolchok @Skylion007 @pytorchbot