[Inductor] Use sleef implementation for CPP backend asinh codegen #142360
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142360
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit cb7679f with merge base ceb664a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: cpu
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "seems to have broken macos tests" -c nosignal example of a broken ci job https://github.com/pytorch/pytorch/actions/runs/12290557650/job/34298356770 |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…egen (#142360)" This reverts commit 79cf8fa. Reverted #142360 on behalf of https://github.com/jeanschmidt due to seems to have broken macos tests ([comment](#142360 (comment)))
|
@leslie-fang-intel your PR has been successfully reverted. |
|
@leslie-fang-intel please rebase your PR and figure out the failures |
|
From the error msg: https://github.com/pytorch/pytorch/actions/runs/12290557650/job/34298356770, probably due to I didn't add the corresponding implementation for MacOS. I have rebased this PR and adding corresponding implementation for other platforms. Check the CI now. |
|
Thanks @malfet, the macos related testing passes. I am going to re-land this PR. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Summary
Fix #142345. Previously, we use
asinh(x) = log(x + sqrt(1 + x**2))to calculate the result ofasinh, the issue happens when input with-10000.1, which makesx + sqrt(1 + x**2)close to 0 and log(0) is invalid. We use thesleefimplementation in this PR to fix this issue.Test Plan
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov