Reapply #142091 (Unbreak dynamic shape minimal arrayref interface tests) #142340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple bug got introduced somewhere. The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those. Differential Revision: [D66890276](https://our.internmc.facebook.com/intern/diff/D66890276/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142340
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 1bce3a3 with merge base 869665c ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66890276 |
This was referenced Dec 8, 2024
hl475
approved these changes
Dec 9, 2024
…ref interface tests)" Simple bug got introduced somewhere. The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those. Differential Revision: [D66890276](https://our.internmc.facebook.com/intern/diff/D66890276/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66890276 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…ensor (#142182) Be explicit about what we are doing, in preparation for adding borrow_arrayref_tensor_as_tensor. Differential Revision: [D66847772](https://our.internmc.facebook.com/intern/diff/D66847772/) Pull Request resolved: #142182 Approved by: https://github.com/desertfire ghstack dependencies: #142340
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Differential Revision: [D66847773](https://our.internmc.facebook.com/intern/diff/D66847773/) Pull Request resolved: #142183 Approved by: https://github.com/desertfire, https://github.com/hl475 ghstack dependencies: #142340, #142182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Simple bug got introduced somewhere.
The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those.
Differential Revision: D66890276
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov