Fix per-sample xfails for NJT tests #142243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142243
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3ee4671 with merge base 822e8a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
approved these changes
Dec 6, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
pytorch#140736 fixed some xfails, but these were not properly failing in CI due to pytorch#142157. This PR removes the xfails so we can land a fix to that issue. Pull Request resolved: pytorch#142243 Approved by: https://github.com/huydhn
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Fixes #142157 Pull Request resolved: #142238 Approved by: https://github.com/malfet, https://github.com/huydhn ghstack dependencies: #142243
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Dec 11, 2024
Fixes pytorch#142157 Pull Request resolved: pytorch#142238 Approved by: https://github.com/malfet, https://github.com/huydhn ghstack dependencies: pytorch#142243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
#140736 fixed some xfails, but these were not properly failing in CI due to #142157. This PR removes the xfails so we can land a fix to that issue.