Add pytest support for unittest.subTests to CI env #142238
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142238
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b44c323 with merge base 822e8a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM, but you can't land as is, as you'll need to tweak xfails at least for NJT tests (good thing it's a stacked PR :) )
|
@malfet True that, just wanted to make sure the signal shows up before I tweak the xfails. I may also add a check for the package to exist and hardfail otherwise :) |
|
@jbschlosser Please add ci-no-td label, or you might be unpleasantly surprised |
Fixes #142157 [ghstack-poisoned]
| "Encountered an OpInfo test with use_subtests=True and pytest-subtests is " | ||
| "not installed. The feature will not work correctly within pytest without " | ||
| "this package; please install it." | ||
| ) from None |
There was a problem hiding this comment.
Don't raise from None, raise from the ModuleNotFoundError instance.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, lf.windows.4xlarge.nonephemeral), trunk / win-vs2019-cpu-py3 / test (default, 3, 3, lf.windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
Fixes #142157 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
|
||
| # TODO: Move both of them to Windows AMI | ||
| python -m pip install pytest-rerunfailures==10.3 pytest-cpp==2.3.0 tensorboard==2.13.0 | ||
| python -m pip install pytest-rerunfailures==10.3 pytest-cpp==2.3.0 tensorboard==2.13.0 pytest-subtests==0.13.1 |
There was a problem hiding this comment.
Now that you mention Windows, I think you will need to add this to https://github.com/pytorch/pytorch/blob/main/.github/requirements/pip-requirements-macOS.txt for mac
Fixes #142157 [ghstack-poisoned]
|
@pytorchbot merge |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#142157 Pull Request resolved: pytorch#142238 Approved by: https://github.com/malfet, https://github.com/huydhn ghstack dependencies: pytorch#142243
Stack from ghstack (oldest at bottom):
Fixes #142157