[AOTI] Refactor codegen_inputs signature #142133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since codegen_inputs only writes to self.prefix, drop IndentedBuffer from its parameters, to make the API consistent with other similar functions. [ghstack-poisoned]
This was referenced Dec 5, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142133
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7edb671 with merge base 91d3054 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Since codegen_inputs only writes to self.prefix, drop IndentedBuffer from its parameters, to make the API consistent with other similar functions. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
chenyang78
approved these changes
Dec 6, 2024
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 8, 2024
Summary: Fixes #141891. JIT Inductor relies on copy_misaligned_inputs to fix misaligned inputs. For AOTInductor's use scenario, this is an unacceptable performance hit, so we codegen input alignment check at the entry point and throws an error if any misalignment exists. Differential Revision: [D66881038](https://our.internmc.facebook.com/intern/diff/D66881038) Pull Request resolved: #142136 Approved by: https://github.com/eellison, https://github.com/ezyang ghstack dependencies: #142133
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
Summary: Since codegen_inputs only writes to self.prefix, drop IndentedBuffer from its parameters, to make the API consistent with other similar functions. Differential Revision: [D66881040](https://our.internmc.facebook.com/intern/diff/D66881040) Pull Request resolved: pytorch#142133 Approved by: https://github.com/chenyang78
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: Fixes #141891. JIT Inductor relies on copy_misaligned_inputs to fix misaligned inputs. For AOTInductor's use scenario, this is an unacceptable performance hit, so we codegen input alignment check at the entry point and throws an error if any misalignment exists. Differential Revision: [D66881038](https://our.internmc.facebook.com/intern/diff/D66881038) Pull Request resolved: #142136 Approved by: https://github.com/eellison, https://github.com/ezyang ghstack dependencies: #142133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Since codegen_inputs only writes to self.prefix, drop IndentedBuffer from its parameters, to make the API consistent with other similar functions.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov
Differential Revision: D66881040