Unbreak dynamic shape minimal arrayref interface tests #142091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple bug got introduced somewhere. Differential Revision: [D66792420](https://our.internmc.facebook.com/intern/diff/D66792420/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142091
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit cec801a with merge base 3fdc74a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66792420 |
Simple bug got introduced somewhere. Differential Revision: [D66792420](https://our.internmc.facebook.com/intern/diff/D66792420/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66792420 |
desertfire
approved these changes
Dec 5, 2024
Simple bug got introduced somewhere. Differential Revision: [D66792420](https://our.internmc.facebook.com/intern/diff/D66792420/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 5, 2024
Pull Request resolved: #142091 Simple bug got introduced somewhere. ghstack-source-id: 256736301 @exported-using-ghexport Differential Revision: [D66792420](https://our.internmc.facebook.com/intern/diff/D66792420/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66792420 |
hl475
approved these changes
Dec 5, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchmergebot revert -c ghfirst -m "Breaks internal changes" |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Dec 6, 2024
…)" This reverts commit 2bfc600. Reverted #142091 on behalf of https://github.com/atalman due to Breaks internal changes ([comment](#142091 (comment)))
Collaborator
|
@swolchok your PR has been successfully reverted. |
swolchok
added a commit
that referenced
this pull request
Dec 6, 2024
Simple bug got introduced somewhere. The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those. Differential Revision: [D66890276](https://our.internmc.facebook.com/intern/diff/D66890276/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 8, 2024
Simple bug got introduced somewhere. The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those. Differential Revision: [D66890276](https://our.internmc.facebook.com/intern/diff/D66890276/) [ghstack-poisoned]
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Simple bug got introduced somewhere. Differential Revision: [D66792420](https://our.internmc.facebook.com/intern/diff/D66792420/) Pull Request resolved: #142091 Approved by: https://github.com/desertfire, https://github.com/hl475
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
…ch#142091)" This reverts commit 2bfc600. Reverted pytorch#142091 on behalf of https://github.com/atalman due to Breaks internal changes ([comment](pytorch#142091 (comment)))
swolchok
added a commit
that referenced
this pull request
Dec 9, 2024
…pe minimal arrayref interface tests)" Simple bug got introduced somewhere. The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those. Differential Revision: [D66890276](https://our.internmc.facebook.com/intern/diff/D66890276/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 9, 2024
…ref interface tests)" Simple bug got introduced somewhere. The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those. Differential Revision: [D66890276](https://our.internmc.facebook.com/intern/diff/D66890276/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…ts) (#142340) Simple bug got introduced somewhere. The original PR was reverted because it broke (caused unexpected successes for) some tests in test_aot_inductor_arrayref.py that still only run internally because #123691 hasn't been fixed. I've fixed those. Differential Revision: [D66890276](https://our.internmc.facebook.com/intern/diff/D66890276/) Pull Request resolved: #142340 Approved by: https://github.com/hl475
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Simple bug got introduced somewhere.
Differential Revision: D66792420
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov