Skip to content

Corrected AMSGrad max equation in Adam and AdamW #142051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Uvi-12 wants to merge 3 commits into from
Closed

Corrected AMSGrad max equation in Adam and AdamW #142051

Uvi-12 wants to merge 3 commits into from

Conversation

@Uvi-12
Copy link
Contributor

@Uvi-12 Uvi-12 commented Dec 4, 2024

Fixes #142041

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142051

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a91608a with merge base 34033cc (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Uvi-12
Copy link
Contributor Author

Uvi-12 commented Dec 4, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 4, 2024
@albanD albanD removed their request for review December 4, 2024 19:50
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 5, 2024
janeyx99
janeyx99 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the optimizer docs changes.

Leaving the batchnorm docs to @mikaylagawarecki

@janeyx99 janeyx99 added topic: docs topic category and removed topic: not user facing topic category labels Dec 5, 2024
@Uvi-12
Copy link
Contributor Author

Uvi-12 commented Dec 5, 2024 •
edited
Loading

Approving the optimizer docs changes.

Leaving the batchnorm docs to @mikaylagawarecki

The batchnorm docs PR is already reviewed and merged #141982

@Uvi-12 Uvi-12 requested a review from janeyx99 December 6, 2024 06:03
@Uvi-12
Copy link
Contributor Author

Uvi-12 commented Dec 6, 2024

@janeyx99 Please approve the workflows, and merge it.

@janeyx99
Copy link
Contributor

janeyx99 commented Dec 6, 2024

@Uvi-12 ah you're likely going to have to rebase then.

@janeyx99
Copy link
Contributor

janeyx99 commented Dec 6, 2024

@pytorchbot merge -r

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 6, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@janeyx99
Copy link
Contributor

janeyx99 commented Dec 6, 2024

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 6, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 6, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 6, 2024

Successfully rebased adam onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout adam && git pull --rebase)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 6, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 6, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@netlify
Copy link

netlify bot commented Dec 6, 2024 •
edited
Loading

✅ Deploy Preview for chimerical-cranachan-793287 ready!

Name Link
🔨 Latest commit a91608a
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-cranachan-793287/deploys/6753464de934c30008f4fead
😎 Deploy Preview https://deploy-preview-142051--chimerical-cranachan-793287.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Uvi-12
Copy link
Contributor Author

Uvi-12 commented Dec 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 6, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 6, 2024

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@janeyx99
Copy link
Contributor

janeyx99 commented Dec 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 6, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@Uvi-12 @AmdSampsa
Corrected AMSGrad max equation in Adam and AdamW (pytorch#142051)
8e394d2 
Fixes pytorch#142041

Pull Request resolved: pytorch#142051
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: optim topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A typo in Adam docs

5 participants

@Uvi-12 @janeyx99 @pytorchmergebot @zou3519 @pytorchbot