Skip to content

[BE] Remove "$PACKAGE_TYPE" == 'conda' logic from build scripts #142019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman wants to merge 2 commits into from
Closed

[BE] Remove "$PACKAGE_TYPE" == 'conda' logic from build scripts #142019

atalman wants to merge 2 commits into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Dec 4, 2024

Please see: #138506

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 4, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142019

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 1 Cancelled Job

As of commit 26c4d75 with merge base 314e08e (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet changed the title Remove PACKAGE_TYPE conda logic from build scripts [BE] Remove PACKAGE_TYPE conda logic from build scripts Dec 4, 2024
huydhn
huydhn approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@malfet malfet changed the title [BE] Remove PACKAGE_TYPE conda logic from build scripts [BE] Remove "$PACKAGE_TYPE" == 'conda' logic from build scripts Dec 4, 2024
malfet
malfet approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please delete dangling scripts (windows/internal/build_conda.batandconda/build/build_pytorch.sh`

.circleci/scripts/binary_linux_build.sh

# Parse the parameters
if [[ "$PACKAGE_TYPE" == 'conda' ]]; then
build_script='conda/build_pytorch.sh'
Copy link
Contributor

@malfet malfet Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete conda/build_pytorch.sh script as well?

Copy link
Contributor Author

@atalman atalman Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe its already deleted by : pytorch/builder#2045

.circleci/scripts/binary_windows_build.sh

pushd "$BUILDER_ROOT"
if [[ "$PACKAGE_TYPE" == 'conda' ]]; then
./windows/internal/build_conda.bat
Copy link
Contributor

@malfet malfet Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, delete windows/internal/build_conda.bat

Copy link
Contributor Author

@atalman atalman Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes posted: pytorch/builder#2047

@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Dec 4, 2024
@atalman
Copy link
Contributor Author

atalman commented Dec 4, 2024

@pytorchmergebot merge -f "Failures are not related"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@atalman
[BE] Remove "$PACKAGE_TYPE" == 'conda' logic from build scripts (py…
c3116f1 
…torch#142019)

Please see: pytorch#138506
Pull Request resolved: pytorch#142019
Approved by: https://github.com/huydhn, https://github.com/malfet
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@atalman @AmdSampsa
[BE] Remove "$PACKAGE_TYPE" == 'conda' logic from build scripts (py…
209c42d 
…torch#142019)

Please see: pytorch#138506
Pull Request resolved: pytorch#142019
Approved by: https://github.com/huydhn, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @huydhn @malfet