[export] Change fx graph _replace_hook to a list of Callable #142006
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142006
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6e05966 with merge base 291626f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66726724 |
yushangdi
force-pushed
the
export-D66726724
branch
from
bd71f34 to
15b1386
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66726724 |
…#142006) Summary: Change fx graph module's _replace_hook from a single hook, to a list of hooks. This is to prepare to registering more hooks for inductor provenance tracking, where we might need to register multiple hooks for node replacement. Test Plan: ``` buck run mode/dev-nosan caffe2/test:fx -- -r test_hooks_for_node_update buck run mode/dev-nosan caffe2/test:test_export -- -r test_replace_hook buck run @//mode/dev-nosan -c fbcode.enable_gpu_sections=true test/distributed/_tensor/experimental:tp_transform ``` Differential Revision: D66726724
yushangdi
force-pushed
the
export-D66726724
branch
from
15b1386 to
6e05966
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66726724 |
zhxchen17
approved these changes
Dec 4, 2024
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
…#142006) Summary: Change fx graph module's _replace_hook from a single hook, to a list of hooks. This is to prepare to registering more hooks for inductor provenance tracking, where we might need to register multiple hooks for node replacement. Test Plan: ``` buck run mode/dev-nosan caffe2/test:fx -- -r test_hooks_for_node_update buck run mode/dev-nosan caffe2/test:test_export -- -r test_replace_hook ``` Differential Revision: D66726724 Pull Request resolved: pytorch#142006 Approved by: https://github.com/zhxchen17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Change fx graph module's _replace_hook from a single hook, to a list of hooks. This is to prepare to registering more hooks for inductor provenance tracking, where we might need to register multiple hooks for node replacement.
Test Plan:
Differential Revision: D66726724
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv