Enable concat support through inductor using pointwise kernels #141966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

nandesuka wants to merge 1 commit into main from export-D66669372

Contributor

nandesuka commented Dec 3, 2024 •

edited

Loading

Summary: Add ability to always force pointwise kernel for concat codegen through Inductor.

Differential Revision: D66669372

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

pytorch-bot bot commented Dec 3, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141966

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 4c92e22 with merge base 0602676 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, lf.linux.4xlarge) (gh) (detected as infra flaky with no log or failing log classifier)

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#141703)
convnext_base
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#141498)
convnext_base

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: inductor labels

Contributor

facebook-github-bot commented Dec 3, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

facebook-github-bot added the fb-exported label

Contributor Author

nandesuka commented Dec 3, 2024

@pytorchbot label "topic: not user facing"

pytorch-bot bot added the topic: not user facing label

nandesuka requested review from Chillee, eellison and jansel

December 3, 2024 20:16

facebook-github-bot force-pushed the export-D66669372 branch from 0d657ce to 6701464 Compare

December 3, 2024 20:19

Contributor

facebook-github-bot commented Dec 3, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

nandesuka requested a review from blaine-rister

December 3, 2024 20:20

facebook-github-bot force-pushed the export-D66669372 branch from 6701464 to 7bf1468 Compare

December 3, 2024 22:28

facebook-github-bot pushed a commit that referenced this pull request


          Enable concat support through inductor using pointwise kernels (#141966)

7bf1468

Summary:

Add ability to always force pointwise kernel for concat codegen through Inductor.

Differential Revision: D66669372

Contributor

facebook-github-bot commented Dec 3, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

nandesuka added a commit that referenced this pull request


          Enable concat support through inductor using pointwise kernels (#141966)

e825f17

Summary:
Pull Request resolved: #141966

Add ability to always force pointwise kernel for concat codegen through Inductor.

Differential Revision: D66669372

Contributor

facebook-github-bot commented Dec 4, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

nandesuka force-pushed the export-D66669372 branch from 7bf1468 to e825f17 Compare

December 4, 2024 19:47

Contributor

facebook-github-bot commented Dec 4, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

nandesuka force-pushed the export-D66669372 branch from e825f17 to b844d53 Compare

December 5, 2024 16:46

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

2 similar comments

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

nandesuka added a commit that referenced this pull request


          Enable concat support through inductor using pointwise kernels (#141966)

033b8d7

Summary:
Pull Request resolved: #141966

Add ability to always force pointwise kernel for concat codegen through Inductor.

Differential Revision: D66669372

nandesuka force-pushed the export-D66669372 branch from b844d53 to 033b8d7 Compare

December 5, 2024 16:53

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

1 similar comment

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

nandesuka force-pushed the export-D66669372 branch from 033b8d7 to ea81208 Compare

December 5, 2024 21:01

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

eellison approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

blaine-rister approved these changes

View reviewed changes

Contributor

blaine-rister left a comment

LGTM! I left one suggested change internally.


          Enable concat support through inductor using pointwise kernels (#141966)

4c92e22

Summary:
Pull Request resolved: #141966

Add ability to always force pointwise kernel for concat codegen through Inductor.

Reviewed By: eellison, blaine-rister

Differential Revision: D66669372

nandesuka force-pushed the export-D66669372 branch from ea81208 to 4c92e22 Compare

December 6, 2024 02:23

Contributor

facebook-github-bot commented Dec 6, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

1 similar comment

Contributor

facebook-github-bot commented Dec 6, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

jansel approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Dec 6, 2024

This pull request was exported from Phabricator. Differential Revision: D66669372

Contributor

facebook-github-bot commented Dec 6, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Dec 6, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

34033cc

pytorchmergebot removed the merging label

AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request


          Enable concat support through inductor using pointwise kernels (pytor…

…ch#141966)

Summary: Add ability to always force pointwise kernel for concat codegen through Inductor.

Differential Revision: D66669372

Pull Request resolved: pytorch#141966
Approved by: https://github.com/eellison, https://github.com/blaine-rister, https://github.com/jansel

github-actions bot deleted the export-D66669372 branch

January 6, 2025 02:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged module: inductor topic: not user facing