Remove monkeypatch of has_frozen_params in test/inductor/test_codecache.py #141898
Conversation
…he.py Summary: This particular test isn't really needed since the code path is already exercised in `test_freezing`. While I was here, I beefed up testing in that method to consider whether the frozen paramater is inlinable vs. not since the caching behavior is different. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141898
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 51375d6 with merge base 5deca07 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…he.py Summary: This particular test isn't really needed since the code path is already exercised in `test_freezing`. While I was here, I beefed up testing in that method to consider whether the frozen paramater is inlinable vs. not since the caching behavior is different. ghstack-source-id: 8ddc781 Pull Request resolved: #141898
| if device == GPU_TYPE and not HAS_GPU: | ||
| raise unittest.SkipTest(f"requires {GPU_TYPE}") | ||
|
|
||
| # For machines with mkldnn_fp16 support, weight_pack in mkldnn_fusion.py causes |
There was a problem hiding this comment.
Somewhat unrelated. The mkldnn special handling below was added after I built this test. I just thought it was making the test overly complicated. If we're bypassing the cache when we find mkldnn tensors, there's not much to test so let's just skip.
| self.reset() | ||
|
|
||
| # Same nn.Module, but with different parameters should cache hit. | ||
| # Same nn.Module, but with different parameters. In the case that the param can |
There was a problem hiding this comment.
Somewhat orthogonal, but this test probably always should have been testing the difference between inlinable vs. not
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…he.py (pytorch#141898) Summary: This particular test isn't really needed since the code path is already exercised in `test_freezing`. While I was here, I beefed up testing in that method to consider whether the frozen paramater is inlinable vs. not since the caching behavior is different. Pull Request resolved: pytorch#141898 Approved by: https://github.com/ezyang, https://github.com/jansel
…he.py (pytorch#141898) Summary: This particular test isn't really needed since the code path is already exercised in `test_freezing`. While I was here, I beefed up testing in that method to consider whether the frozen paramater is inlinable vs. not since the caching behavior is different. Pull Request resolved: pytorch#141898 Approved by: https://github.com/ezyang, https://github.com/jansel
Stack from ghstack (oldest at bottom):
Summary: This particular test isn't really needed since the code path is already exercised in
test_freezing. While I was here, I beefed up testing in that method to consider whether the frozen paramater is inlinable vs. not since the caching behavior is different.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov