Type exposed_in decorator #141894
Closed
Type exposed_in decorator #141894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: - lintrunner [ghstack-poisoned]
zou3519
requested review from
albanD,
jbschlosser and
mikaylagawarecki
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141894
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b22b108 with merge base 9012e7a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 2, 2024
Test Plan: - lintrunner [ghstack-poisoned]
Skylion007
reviewed
Dec 3, 2024
| device_types: device_types_t = None, | ||
| schema: Optional[str] = None, | ||
| ) -> Callable: | ||
| ) -> Any: |
Collaborator
There was a problem hiding this comment.
Why remove this valuable typing?
Skylion007
reviewed
Dec 3, 2024
| from typing import Callable, TypeVar | ||
|
|
||
|
|
||
| F = TypeVar("F") |
Collaborator
There was a problem hiding this comment.
Suggested change
| F = TypeVar("F") | |
| _F = TypeVar("_F") |
No reason for the TypeVar to be public
Contributor
Author
There was a problem hiding this comment.
This file isn't public (the path is torch.utils._exposed_in) so F isn't public
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 3, 2024
We've been using it privately for half a year and everything's been good. This PR: 1. Makes torch.library.triton_op public 2. Renames capture_triton -> wrap_triton. We got feedback that no one knew what "capture triton" does. 3. Makes torch.library.wrap_triton public. triton_op is used to construct a Python custom operator that may call 1+ triton kernels. Each of those triton kernels must be annotated with wrap_triton. Test Plan: - existing tests Pull Request resolved: #141880 Approved by: https://github.com/albanD ghstack dependencies: #141894
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Fixes #141618 Pull Request resolved: #141883 Approved by: https://github.com/albanD ghstack dependencies: #141894, #141880
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Test Plan: - lintrunner Pull Request resolved: pytorch#141894 Approved by: https://github.com/albanD
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
We've been using it privately for half a year and everything's been good. This PR: 1. Makes torch.library.triton_op public 2. Renames capture_triton -> wrap_triton. We got feedback that no one knew what "capture triton" does. 3. Makes torch.library.wrap_triton public. triton_op is used to construct a Python custom operator that may call 1+ triton kernels. Each of those triton kernels must be annotated with wrap_triton. Test Plan: - existing tests Pull Request resolved: pytorch#141880 Approved by: https://github.com/albanD ghstack dependencies: pytorch#141894
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
) Fixes pytorch#141618 Pull Request resolved: pytorch#141883 Approved by: https://github.com/albanD ghstack dependencies: pytorch#141894, pytorch#141880
zou3519
added a commit
that referenced
this pull request
Dec 5, 2024
Summary: #141894 made this API actually typed w.r.t. pyre, which is causing some internal type failures. This PR expands the typing for stack_module_state to squash those failures. Test Plan: - pyre [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Summary: #141894 made this API actually typed w.r.t. pyre, which is causing some internal type failures. This PR expands the typing for stack_module_state to squash those failures. Test Plan: - pyre Pull Request resolved: #142169 Approved by: https://github.com/albanD
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
Test Plan: - lintrunner Pull Request resolved: pytorch#141894 Approved by: https://github.com/albanD
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
We've been using it privately for half a year and everything's been good. This PR: 1. Makes torch.library.triton_op public 2. Renames capture_triton -> wrap_triton. We got feedback that no one knew what "capture triton" does. 3. Makes torch.library.wrap_triton public. triton_op is used to construct a Python custom operator that may call 1+ triton kernels. Each of those triton kernels must be annotated with wrap_triton. Test Plan: - existing tests Pull Request resolved: pytorch#141880 Approved by: https://github.com/albanD ghstack dependencies: pytorch#141894
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
) Fixes pytorch#141618 Pull Request resolved: pytorch#141883 Approved by: https://github.com/albanD ghstack dependencies: pytorch#141894, pytorch#141880
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: #141894 made this API actually typed w.r.t. pyre, which is causing some internal type failures. This PR expands the typing for stack_module_state to squash those failures. Test Plan: - pyre Pull Request resolved: #142169 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test Plan: