Inline compile_to_fn at its only call site #141691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141691
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit b449da4 with merge base 0f261e8 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 2ca13e6 Pull Request resolved: #141691
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
ezyang
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 2ca13e6 Pull Request resolved: #141691
ezyang
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 2ca13e6 Pull Request resolved: #141691
ezyang
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 2ca13e6 Pull Request resolved: #141691
jansel
approved these changes
Nov 27, 2024
ezyang
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: e9fc5cb Pull Request resolved: #141691
ezyang
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: e9fc5cb Pull Request resolved: #141691
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
ezyang
added a commit
that referenced
this pull request
Nov 28, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: a4e5be2 Pull Request resolved: #141691
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 30, 2024
Stacked on #141691 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #141695 Approved by: https://github.com/aorenste ghstack dependencies: #141681, #141683, #141685, #141688, #141689, #141691
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Stacked on pytorch#141689 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#141691 Approved by: https://github.com/jansel ghstack dependencies: pytorch#141681, pytorch#141683, pytorch#141685, pytorch#141688, pytorch#141689
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Stacked on pytorch#141691 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#141695 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#141681, pytorch#141683, pytorch#141685, pytorch#141688, pytorch#141689, pytorch#141691
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 550343a Pull Request resolved: pytorch/pytorch#141691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Stacked on #141689
Signed-off-by: Edward Z. Yang [email protected]
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov