Hoist post_compile1 into fx_codegen_and_compile #141688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141688
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 44f4327 with merge base 0f261e8 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
ezyang
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 03ea0b9 Pull Request resolved: #141688
Skylion007
approved these changes
Nov 27, 2024
jansel
approved these changes
Nov 27, 2024
This was referenced Nov 28, 2024
Contributor
Author
|
In obscure situations, this apparently does not work. |
ezyang
changed the title
Contributor
Author
|
I have completely redone this. Instead of hoisting post_compile1 so that it is next to post_compile2, I have hoisted it so that it is next to CompiledFxGraph constructor. In the next PR, instead of unifying post_compile1 and post_compile2, I will now unify it with the constructor. |
Contributor
Author
|
Beh, it was simpler not to recompute get_input_idxs_to_check but I checked more carefully and it's bad, I better not recompute it |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 29, 2024
Stacked on #141688 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #141689 Approved by: https://github.com/jansel ghstack dependencies: #141681, #141683, #141685, #141688
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 29, 2024
Stacked on #141689 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #141691 Approved by: https://github.com/jansel ghstack dependencies: #141681, #141683, #141685, #141688, #141689
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 30, 2024
Stacked on #141691 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #141695 Approved by: https://github.com/aorenste ghstack dependencies: #141681, #141683, #141685, #141688, #141689, #141691
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Stacked on top of pytorch#141685 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#141688 Approved by: https://github.com/Skylion007, https://github.com/jansel ghstack dependencies: pytorch#141681, pytorch#141683, pytorch#141685
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Stacked on pytorch#141688 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#141689 Approved by: https://github.com/jansel ghstack dependencies: pytorch#141681, pytorch#141683, pytorch#141685, pytorch#141688
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Stacked on pytorch#141689 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#141691 Approved by: https://github.com/jansel ghstack dependencies: pytorch#141681, pytorch#141683, pytorch#141685, pytorch#141688, pytorch#141689
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Stacked on pytorch#141691 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#141695 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#141681, pytorch#141683, pytorch#141685, pytorch#141688, pytorch#141689, pytorch#141691
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: afa878c Pull Request resolved: pytorch/pytorch#141688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Stacked on top of #141685
Signed-off-by: Edward Z. Yang [email protected]
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov