[dim_order] raised runtime error when tensor has ambiguous dim order #141632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141632
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0fca280 with merge base b64a537 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65133579 |
… dim order" This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Nov 27, 2024
Pull Request resolved: #141632 This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ ghstack-source-id: 255575695 @exported-using-ghexport Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65133579 |
Contributor
Author
|
@pytorchbot label "release notes: nn" |
… dim order" This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65133579 |
Gasoonjia
added a commit
that referenced
this pull request
Dec 2, 2024
Pull Request resolved: #141632 This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ ghstack-source-id: 256109328 @exported-using-ghexport Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/)
… dim order" This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65133579 |
Gasoonjia
added a commit
that referenced
this pull request
Dec 7, 2024
Pull Request resolved: #141632 This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ ghstack-source-id: 257005597 @exported-using-ghexport Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/)
larryliu0820
approved these changes
Dec 7, 2024
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…141632) This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/ Differential Revision: [D65133579](https://our.internmc.facebook.com/intern/diff/D65133579/) Pull Request resolved: #141632 Approved by: https://github.com/larryliu0820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff makes tensor.dim_order() raise error when tensor's dim order is ambiguous. Detail discussion can be found https://fb.workplace.com/groups/894363187646754/permalink/2039987243084337/
Differential Revision: D65133579