Skip to content

Update triton wheel install script with new versioning #141497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjaminglass1 wants to merge 1 commit into from
Closed

Update triton wheel install script with new versioning #141497

benjaminglass1 wants to merge 1 commit into from

Conversation

@benjaminglass1
Copy link
Collaborator

@benjaminglass1 benjaminglass1 commented Nov 25, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR is a follow-on to #141410.

@benjaminglass1
Update
7b65202 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 25, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141497

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7b65202 with merge base d0fd42e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

benjaminglass1 added a commit that referenced this pull request Nov 25, 2024
@benjaminglass1
Update triton wheel install script with new versioning
a6c3390 
This PR is a follow-on to #141410.

ghstack-source-id: 1bd6033
Pull Request resolved: #141497
@benjaminglass1 benjaminglass1 self-assigned this Nov 25, 2024
@amjames amjames requested review from atalman and huydhn November 25, 2024 18:55
huydhn
huydhn approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@huydhn
Copy link
Contributor

huydhn commented Nov 25, 2024

@pytorchbot merge -f 'CI only change, this should be ok to land'

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@benjaminglass1 @Ryo-not-rio
Update triton wheel install script with new versioning (pytorch#141497)
615058b 
This PR is a follow-on to pytorch#141410.
Pull Request resolved: pytorch#141497
Approved by: https://github.com/huydhn
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@benjaminglass1
Update triton wheel install script with new versioning (pytorch#141497)
fb07f56 
This PR is a follow-on to pytorch#141410.
Pull Request resolved: pytorch#141497
Approved by: https://github.com/huydhn
@DDEle DDEle mentioned this pull request Dec 11, 2024
Closed
@github-actions github-actions bot deleted the gh/benjaminglass1/36/head branch December 26, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees

@benjaminglass1 benjaminglass1

Labels

Merged open source test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminglass1 @huydhn @pytorchmergebot @pytorchbot