Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 25, 2024

@malfet malfet requested a review from kulinseth as a code owner November 25, 2024 06:11
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141477

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 715eb74 with merge base 2398e75 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 changed the title [MPS] Make MetalSahderLibrary usable from C++ [MPS] Make MetalShaderLibrary usable from C++ Nov 25, 2024
@malfet
Copy link
Contributor Author

malfet commented Nov 25, 2024

@pytorchbot merge -f "MPS + Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
By guarding Metal framework include and defining all ObjC protocols to dummy `void*`
Pull Request resolved: pytorch#141477
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#141474, pytorch#141475, pytorch#141476
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
By guarding Metal framework include and defining all ObjC protocols to dummy `void*`
Pull Request resolved: pytorch#141477
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#141474, pytorch#141475, pytorch#141476
@github-actions github-actions bot deleted the gh/malfet/70/head branch December 26, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants