[MPS] Move MetalShaderLibrary to its own header #141475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141475
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f3e813f with merge base 2398e75 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
This was referenced Nov 25, 2024
Skylion007
reviewed
Nov 25, 2024
| public: | ||
| MetalShaderLibrary(const std::string& src) | ||
| : shaderSource(src), nparams(0), compile_options(nullptr) {} | ||
| MetalShaderLibrary(const std::string& src, unsigned nparams_) |
Collaborator
There was a problem hiding this comment.
nit some of these strings by might be better as move by value instead of const ref since they are immeaditely stored in a member variable.
Skylion007
approved these changes
Nov 25, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 25, 2024
As classes with virtual methods must have virtual destructors Pull Request resolved: #141476 Approved by: https://github.com/cyyever, https://github.com/Skylion007 ghstack dependencies: #141474, #141475
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 25, 2024
By guarding Metal framework include and defining all ObjC protocols to dummy `void*` Pull Request resolved: #141477 Approved by: https://github.com/Skylion007 ghstack dependencies: #141474, #141475, #141476
This was referenced Nov 25, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 27, 2024
That returns names of all the function in shader Pull Request resolved: #141499 Approved by: https://github.com/manuelcandales, https://github.com/Skylion007 ghstack dependencies: #141474, #141475, #141476, #141477
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
In preparation to be used from libtorch_python Pull Request resolved: pytorch#141475 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#141474
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
As classes with virtual methods must have virtual destructors Pull Request resolved: pytorch#141476 Approved by: https://github.com/cyyever, https://github.com/Skylion007 ghstack dependencies: pytorch#141474, pytorch#141475
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
By guarding Metal framework include and defining all ObjC protocols to dummy `void*` Pull Request resolved: pytorch#141477 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#141474, pytorch#141475, pytorch#141476
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
That returns names of all the function in shader Pull Request resolved: pytorch#141499 Approved by: https://github.com/manuelcandales, https://github.com/Skylion007 ghstack dependencies: pytorch#141474, pytorch#141475, pytorch#141476, pytorch#141477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In preparation to be used from libtorch_python