Fix pytorch-triton nightly checksum shorthash #141410
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141410
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5b7817c with merge base eb954ef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
changed the title
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "Let's not wait for trunk" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'There is still a small tweak that I need to do 35c6c7c628 is now git35c6c7c6 so a prefix is needed, going to revert and reland this' -c ignoredsignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 9f8a191. Reverted #141410 on behalf of https://github.com/huydhn due to There is still a small tweak that I need to do 35c6c7c628 is now git35c6c7c6 so a prefix is needed, going to revert and reland this ([comment](#141410 (comment)))
|
@huydhn your PR has been successfully reverted. |
huydhn
changed the title
|
@pytorchbot merge -f 'Land and run in trunk to avoid ephemeral queue' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This PR is a follow-on to #141410. Pull Request resolved: #141497 Approved by: https://github.com/huydhn
|
@huydhn Thank you for fixing this! 🙏 |
Binary build is failing in trunk after pytorch#139206 lands, for example, https://github.com/pytorch/pytorch/actions/runs/11981181986/job/33410250461#step:17:539. It's a bit tricky to spot the issue but the difference is between `3.2.0+35c6c7c628` set by PyTorch and `3.2.0+git35c6c7c6` from triton (look closely one has the length of 10, the other of 8 characters) Triton now has its own nightly build logic in triton-lang/triton#4812 that takes only 8 characters by default while the original logic from PT took 10. So, PT nightly couldn't find the dependency. Pull Request resolved: pytorch#141410 Approved by: https://github.com/seemethere, https://github.com/malfet
This reverts commit 9f8a191. Reverted pytorch#141410 on behalf of https://github.com/huydhn due to There is still a small tweak that I need to do 35c6c7c628 is now git35c6c7c6 so a prefix is needed, going to revert and reland this ([comment](pytorch#141410 (comment)))
Binary build is failing in trunk after pytorch#139206 lands, for example, https://github.com/pytorch/pytorch/actions/runs/11981181986/job/33410250461#step:17:539. It's a bit tricky to spot the issue but the difference is between `3.2.0+35c6c7c628` set by PyTorch and `3.2.0+git35c6c7c6` from triton (look closely one has the length of 10, the other of 8 characters) Triton now has its own nightly build logic in triton-lang/triton#4812 that takes only 8 characters by default while the original logic from PT took 10. So, PT nightly couldn't find the dependency. Pull Request resolved: pytorch#141410 Approved by: https://github.com/seemethere, https://github.com/malfet
This PR is a follow-on to pytorch#141410. Pull Request resolved: pytorch#141497 Approved by: https://github.com/huydhn
5 participants
Binary build is failing in trunk after #139206 lands, for example, https://github.com/pytorch/pytorch/actions/runs/11981181986/job/33410250461#step:17:539. It's a bit tricky to spot the issue but the difference is between
3.2.0+35c6c7c628set by PyTorch and3.2.0+git35c6c7c6from triton (look closely one has the length of 10, the other of 8 characters)Triton now has its own nightly build logic in triton-lang/triton#4812 that takes only 8 characters by default while the original logic from PT took 10. So, PT nightly couldn't find the dependency.