[c10d][CI] Use new store for PG restart tests #141374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141374
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 94348a1 with merge base 740d1eb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
A new store is used to recreate PGs upon restart. Here are the step to achieve new store in CI: - Rank 0 creates a temp file, share the file name via an old store. - Non-0 rank get the file name via the old store. - All ranks creates a new store. There was existing code for the above steps, this PR just exact it out into a util function, and share with other restart tests. Also moved restart tests together under `NcclErrorHandlingTest` class. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
kwen2501
changed the title
This was referenced Nov 22, 2024
fduwjj
approved these changes
Nov 25, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 25, 2024
…calls (#141270) ### Motivation `ncclCommInitRank` needs GPU guard (documented in NCCL). `ncclCommAbort`, `ncclCommFinalize` and `ncclCommDestroy` may also need GPU guard (undocumented in NCCL); otherwise, extra CUDA context may be created (or worse, hang); both effects have been seen before in our tests. ### Solution This PR records a device index during `NCCLComm` object creation, so that we can add GPU guard in `NCCLComm`'s method calling which direct to the above NCCL APIs. ### Note This is not a bug fix. Just a safety improvement. Pull Request resolved: #141270 Approved by: https://github.com/eqy ghstack dependencies: #141374
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
A new Store is used to recreate PGs upon restart. Achieve the new Store by adding prefix. Pull Request resolved: pytorch#141374 Approved by: https://github.com/fduwjj
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…calls (pytorch#141270) ### Motivation `ncclCommInitRank` needs GPU guard (documented in NCCL). `ncclCommAbort`, `ncclCommFinalize` and `ncclCommDestroy` may also need GPU guard (undocumented in NCCL); otherwise, extra CUDA context may be created (or worse, hang); both effects have been seen before in our tests. ### Solution This PR records a device index during `NCCLComm` object creation, so that we can add GPU guard in `NCCLComm`'s method calling which direct to the above NCCL APIs. ### Note This is not a bug fix. Just a safety improvement. Pull Request resolved: pytorch#141270 Approved by: https://github.com/eqy ghstack dependencies: pytorch#141374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
A new Store is used to recreate PGs upon restart. Achieve the new Store by adding prefix.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o