[dynamo] fix generic namedtuple support when the class is created via class MyTuple(NamedTuple, Generic[T]): ...
#141360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141360
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 890cb53 with merge base 9dd3b85 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 22, 2024
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 22, 2024
… `class MyTuple(NamedTuple, Generic[T]): ...` ghstack-source-id: 6999a18 Pull Request resolved: pytorch#141360
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 26, 2024
… `class MyTuple(NamedTuple, Generic[T]): ...` ghstack-source-id: eaed427 Pull Request resolved: pytorch#141360
jansel
approved these changes
Nov 26, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 27, 2024
…leaves` (#137397) Pull Request resolved: #137397 Approved by: https://github.com/jansel ghstack dependencies: #141360
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Dec 2, 2024
Summary: X-link: pytorch/pytorch#141360 Approved by: https://github.com/jansel Reviewed By: atalman Differential Revision: D66524965 fbshipit-source-id: 9033a6685cbaf2c023b1ee8ce60e7680deeb0650
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
… `class MyTuple(NamedTuple, Generic[T]): ...` (pytorch#141360) Pull Request resolved: pytorch#141360 Approved by: https://github.com/jansel
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…leaves` (pytorch#137397) Pull Request resolved: pytorch#137397 Approved by: https://github.com/jansel ghstack dependencies: pytorch#141360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
torch.utils.pytreeby default #138056torch.func#137884torch.utils.pytree#137400tree_map/tree_map_#137399dictkeys in insertion order in CXX pytree #130140tree_flatten/tree_unflatten/tree_structure#137398tree_iter/tree_leaves#137397class MyTuple(NamedTuple, Generic[T]): ...#141360cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames