Skip to content

Support linear/BN fusion #141352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaewoosong wants to merge 3 commits into from
Closed

Support linear/BN fusion #141352

jaewoosong wants to merge 3 commits into from

Conversation

@jaewoosong
Copy link
Contributor

@jaewoosong jaewoosong commented Nov 22, 2024 •
edited by pytorch-bot bot
Loading

Current fuse function supports conv/BN fusions only. This commit is to support linear/BN fusion as well.

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

@jaewoosong
Support linear/BN fusion
48855c4 
Current `fuse` function supports conv/BN fusions only. This commit is to support linear/BN fusion as well.
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141352

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit b110b9c with merge base cf1d95a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

  • linux-binary-manywheel / manywheel-py3_9-cuda11_8-test / test (gh) (similar failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)
  • linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test (gh) (similar failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)
  • linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh) (similar failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 22, 2024
@ezyang
Copy link
Contributor

ezyang commented Nov 24, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 24, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 24, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jaewoosong
Copy link
Contributor Author

jaewoosong commented Nov 24, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 24, 2024

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jaewoosong
Copy link
Contributor Author

jaewoosong commented Nov 24, 2024

@ezyang Thank you for your review and approval. Would you please command @pytorchbot to merge this PR again? After you commanded @pytorchbot to merge this, there were lint formatting and API guideline errors so I fixed them. Now the CI tests say this PR can be merged normally. The fixes I added are irrelevant to the functionality and just for fixing lint and API guideline errors.

@jaewoosong
Copy link
Contributor Author

jaewoosong commented Nov 26, 2024

@ezyang Would you please merge this PR? This PR was already approved by you, and I fixed the lint and API guideline problems after your approval.

@jaewoosong jaewoosong mentioned this pull request Nov 26, 2024
Closed
@jaewoosong
Copy link
Contributor Author

jaewoosong commented Nov 26, 2024

I created a new PR at #141585. After it is merged, this PR will be closed.

@ezyang ezyang closed this Nov 27, 2024
pytorchmergebot pushed a commit that referenced this pull request Nov 27, 2024
@jaewoosong @pytorchmergebot
Support linear/BN fusion and follow the API guideline (#141585)
43a2a23 
Current `fuse` function supports conv/BN fusions only. This commit is to support linear/BN fusion as well. Changes to follow the API guidelines are also applied.

(This will close the PR #141352 which I created for the same topic and got approval but had lint and API guideline problems.)

Pull Request resolved: #141585
Approved by: https://github.com/ezyang
@jaewoosong jaewoosong deleted the patch-1 branch December 3, 2024 12:19
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@jaewoosong
Support linear/BN fusion and follow the API guideline (pytorch#141585)
2539d94 
Current `fuse` function supports conv/BN fusions only. This commit is to support linear/BN fusion as well. Changes to follow the API guidelines are also applied.

(This will close the PR pytorch#141352 which I created for the same topic and got approval but had lint and API guideline problems.)

Pull Request resolved: pytorch#141585
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx open source release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaewoosong @ezyang @pytorchmergebot @facebook-github-bot @pytorchbot