Skip to content

Conversation

@chuanqi129
Copy link
Collaborator

@chuanqi129 chuanqi129 commented Nov 22, 2024

Add requirements.txt installation when the widnows ci build env preparation

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141318

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit f608d1a with merge base 51b6126 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@chuanqi129 chuanqi129 added ciflow/xpu Run XPU CI tasks topic: not user facing topic category labels Nov 22, 2024
@chuanqi129 chuanqi129 marked this pull request as ready for review November 22, 2024 05:04
@chuanqi129 chuanqi129 requested a review from a team as a code owner November 22, 2024 05:04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to call pip list after pip install here to see its final state? It's fine if you want to do it both before and after

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think it's interesting to see what's present in the AMI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just as @malfet said

@huydhn
Copy link
Contributor

huydhn commented Nov 22, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_win_ci onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix_win_ci && git pull --rebase)

@malfet
Copy link
Contributor

malfet commented Nov 22, 2024

@pytorchot merge -f "This sounds OK to me"

@malfet malfet self-requested a review November 22, 2024 18:03
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can you please elaborate why this only surfaces for XPU builds, but not for the regular torch ones?
Instead of pinning distutils, can't we get rid of deprecated path and remove the constraint?

@chuanqi129
Copy link
Collaborator Author

chuanqi129 commented Nov 22, 2024

Hmm, can you please elaborate why this only surfaces for XPU builds, but not for the regular torch ones? Instead of pinning distutils, can't we get rid of deprecated path and remove the constraint?

Hi @malfet, thanks for your review and comments. I'm also not sure why just xpu windows build met this issue, because I didn't find where those required packages installed into the Windows runner env. The only thing I can check is that the setuptools version is 72.1.0 for cpu windows build used runner, but the xpu used runner is 75.1.0. And I also agree with your suggestion to remove the deprecated path and move forward, I think we can have another PR to do it. And this PR change is safe enough and necessary to make sure such issue won't appear in the future. I suggest to land this PR firstly to unblock XPU CI test for other PRs. How do you think?

@chuanqi129 chuanqi129 requested review from huydhn and malfet November 22, 2024 19:18
@guangyey
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_win_ci onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_win_ci && git pull --rebase)

@guangyey
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_win_ci onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_win_ci && git pull --rebase)

@chuanqi129 chuanqi129 changed the title Fix windows ci build python env issue Add requirements.txt installation for windows ci build env Nov 25, 2024
@chuanqi129
Copy link
Collaborator Author

Due to the original issue #141319 has been fixed by #141363, I have updated the PR title and description. @malfet @huydhn do you think whether this is a reasonable change?

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 26, 2024
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jan 25, 2025
@github-actions github-actions bot closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/xpu Run XPU CI tasks open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants