-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Add requirements.txt installation for windows ci build env #141318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141318
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit f608d1a with merge base 51b6126 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to call pip list after pip install here to see its final state? It's fine if you want to do it both before and after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think it's interesting to see what's present in the AMI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just as @malfet said
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
ef734ab to
c6d2cc3
Compare
|
@pytorchot merge -f "This sounds OK to me" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, can you please elaborate why this only surfaces for XPU builds, but not for the regular torch ones?
Instead of pinning distutils, can't we get rid of deprecated path and remove the constraint?
Hi @malfet, thanks for your review and comments. I'm also not sure why just xpu windows build met this issue, because I didn't find where those required packages installed into the Windows runner env. The only thing I can check is that the setuptools version is 72.1.0 for cpu windows build used runner, but the xpu used runner is 75.1.0. And I also agree with your suggestion to remove the deprecated path and move forward, I think we can have another PR to do it. And this PR change is safe enough and necessary to make sure such issue won't appear in the future. I suggest to land this PR firstly to unblock XPU CI test for other PRs. How do you think? |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
c6d2cc3 to
4286476
Compare
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
4286476 to
f608d1a
Compare
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Add requirements.txt installation when the widnows ci build env preparation