Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 22, 2024

Stack from ghstack (oldest at bottom):

To point to #141287 as well as reference commit hash (to clearly distringiush between OPs that has been implemented in trunk vs ones that are still missing)

[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner November 22, 2024 02:00
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Nov 22, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141314

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c28298a with merge base f708e92 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet and others added 2 commits November 21, 2024 19:09
[ghstack-poisoned]
[ghstack-poisoned]
malfet added a commit that referenced this pull request Nov 25, 2024
To point to #141287 as well as reference commit hash (to clearly distinct between OPs that just need a rebase)

ghstack-source-id: 1b74a73
Pull Request resolved: #141314
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@malfet
Copy link
Contributor Author

malfet commented Nov 27, 2024

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
To point to pytorch#141287 as well as reference commit hash (to clearly distringiush  between OPs that has been implemented in trunk vs ones that are still missing)
Pull Request resolved: pytorch#141314
Approved by: https://github.com/manuelcandales, https://github.com/albanD
ghstack dependencies: pytorch#141313
@github-actions github-actions bot deleted the gh/malfet/66/head branch December 27, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants