Skip to content

Migrate pull jobs cuda12.1->cuda12.4 #141271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman wants to merge 1 commit into from
Closed

Migrate pull jobs cuda12.1->cuda12.4 #141271

atalman wants to merge 1 commit into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Nov 21, 2024 •
edited
Loading

Cuda 12.1 nightly builds where deprecated. Hence no reason on keep testing cuda 12.1 in CI

@atalman atalman requested a review from a team as a code owner November 21, 2024 19:47
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 21, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141271

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit e695cd1 with merge base a847790 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv
Copy link
Collaborator

tinglvv commented Nov 21, 2024

Thanks for the update 👍

malfet
malfet approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we migrate existing 12.4 to 12.6 then?

@huydhn
Copy link
Contributor

huydhn commented Nov 21, 2024

Shouldn't we migrate existing 12.4 to 12.6 then?

There are a number of existing CUDA 12.4 that should either be cleaned up or updated to 12.6, for example:

(There might be more of them)

@atalman
Copy link
Contributor Author

atalman commented Nov 21, 2024

Check for duplicates: https://hud2.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=pull%20%2F%20linux-focal-cuda&mergeLF=true

@atalman
Copy link
Contributor Author

atalman commented Nov 21, 2024

@huydhn I believe @tinglvv will be looking into adding 12.6 CI jobs.

@atalman
Copy link
Contributor Author

atalman commented Nov 21, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn mentioned this pull request Dec 4, 2024
Closed
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@atalman
Migrate pull jobs cuda12.1->cuda12.4 (pytorch#141271)
dc4c977 
Cuda 12.1 nightly builds where deprecated. Hence no reason on keep testing cuda 12.1 in CI
Pull Request resolved: pytorch#141271
Approved by: https://github.com/Skylion007, https://github.com/malfet, https://github.com/huydhn
@atalman atalman mentioned this pull request Dec 12, 2024
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@atalman @tinglvv @huydhn @pytorchmergebot @Skylion007 @malfet