Fix AttributeError: 'int' object has no attribute 'node' due to constant prop #141250

ezyang · 2024-11-21T16:23:34Z

Stack from ghstack (oldest at bottom):

-> Fix AttributeError: 'int' object has no attribute 'node' due to constant prop #141250

Fixes #140625

Signed-off-by: Edward Z. Yang [email protected]

cc @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

[ghstack-poisoned]

pytorch-bot · 2024-11-21T16:23:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141250

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4f961c3 with merge base 4c1f50a ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
convnext_base

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ant prop Fixes #140625 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: bcb22c6 Pull Request resolved: #141250

ezyang · 2024-11-22T05:04:31Z

@pytorchbot merge

pytorchmergebot · 2024-11-22T05:06:19Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-11-22T05:06:42Z

Merge failed

Reason: 1 jobs have failed, first few of them are: Check mergeability of ghstack PR / ghstack-mergeability-check

Details for Dev Infra team

Raised by workflow job

ezyang · 2024-11-22T17:52:45Z

@pytorchbot merge -f "failures look unrelated"

pytorchmergebot · 2024-11-22T17:54:35Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-11-22T17:54:48Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 485b8173f0e3964fe9765a042c9be4ef29668cb8 returned non-zero exit code 1

Auto-merging test/export/test_draft_export.py
CONFLICT (content): Merge conflict in test/export/test_draft_export.py
Auto-merging torch/fx/experimental/symbolic_shapes.py
error: could not apply 485b8173f0e... Fix AttributeError: 'int' object has no attribute 'node' due to constant prop
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

[ghstack-poisoned]

ezyang · 2024-11-24T02:58:39Z

@pytorchbot merge

pytorchmergebot · 2024-11-24T03:01:28Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-11-24T03:01:43Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / get-label-type / runner-determinator

Details for Dev Infra team

Raised by workflow job

[ghstack-poisoned]

…ant prop Fixes #140625 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: a9f9ee5 Pull Request resolved: #141250

ezyang · 2024-11-24T04:41:36Z

@pytorchbot merge

pytorchmergebot · 2024-11-24T04:43:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ant prop (pytorch#141250) Fixes pytorch#140625 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#141250 Approved by: https://github.com/bobrenjc93

Update

2a469dc

[ghstack-poisoned]

ezyang added a commit that referenced this pull request Nov 21, 2024

Fix AttributeError: 'int' object has no attribute 'node' due to const…

485b817

…ant prop Fixes #140625 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: bcb22c6 Pull Request resolved: #141250

pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Nov 21, 2024

facebook-github-bot added the fx label Nov 21, 2024

github-actions bot requested review from SherlockNoMad, albanD, antoniojkim, bdhirsh and miladm November 21, 2024 16:23

ezyang requested review from bobrenjc93 and laithsakka November 21, 2024 16:24

bobrenjc93 approved these changes Nov 21, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 22, 2024

pytorchmergebot added the merging label Nov 22, 2024

pytorchmergebot removed the merging label Nov 22, 2024

pytorchmergebot added the merging label Nov 22, 2024

pytorchmergebot removed the merging label Nov 22, 2024

Update

316c065

[ghstack-poisoned]

pytorchmergebot added the merging label Nov 24, 2024

pytorchmergebot removed the merging label Nov 24, 2024

Update

4f961c3

[ghstack-poisoned]

ezyang added a commit that referenced this pull request Nov 24, 2024

Fix AttributeError: 'int' object has no attribute 'node' due to const…

cecb99c

…ant prop Fixes #140625 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: a9f9ee5 Pull Request resolved: #141250

pytorchmergebot added the merging label Nov 24, 2024

pytorchmergebot added the Merged label Nov 24, 2024

pytorchmergebot closed this in a87925c Nov 24, 2024

pytorchmergebot removed the merging label Nov 24, 2024

github-actions bot deleted the gh/ezyang/3006/head branch December 25, 2024 02:04

Fix AttributeError: 'int' object has no attribute 'node' due to constant prop #141250

Fix AttributeError: 'int' object has no attribute 'node' due to constant prop #141250

Uh oh!

Conversation

ezyang commented Nov 21, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141250

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

ezyang commented Nov 22, 2024

Uh oh!

pytorchmergebot commented Nov 22, 2024

Merge started

Uh oh!

pytorchmergebot commented Nov 22, 2024

Merge failed

Uh oh!

ezyang commented Nov 22, 2024

Uh oh!

pytorchmergebot commented Nov 22, 2024

Merge started

Uh oh!

pytorchmergebot commented Nov 22, 2024

Merge failed

Uh oh!

ezyang commented Nov 24, 2024

Uh oh!

pytorchmergebot commented Nov 24, 2024

Merge started

Uh oh!

pytorchmergebot commented Nov 24, 2024

Merge failed

Uh oh!

ezyang commented Nov 24, 2024

Uh oh!

pytorchmergebot commented Nov 24, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ezyang commented Nov 21, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Nov 21, 2024 •

edited

Loading