Skip to content

Fix stride in TensorMetadata to always be a Tuple[int, ...] #141106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marvin-kim wants to merge 1 commit into from
Closed

Fix stride in TensorMetadata to always be a Tuple[int, ...] #141106

marvin-kim wants to merge 1 commit into from

Conversation

@marvin-kim
Copy link
Contributor

@marvin-kim marvin-kim commented Nov 20, 2024 •
edited by pytorch-bot bot
Loading

Test Plan: CI

Differential Revision: D66204410

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141106

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit cfe1d50 with merge base 4c9e77d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 20, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: marvin-kim / name: Marvin Kim (cfe1d50)

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 20, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2024

This pull request was exported from Phabricator. Differential Revision: D66204410

@marvin-kim
Copy link
Contributor Author

marvin-kim commented Nov 20, 2024

/easycla

@marvin-kim @facebook-github-bot
Fix stride in TensorMetadata to always be a Tuple[int, ...] (pyto…
cfe1d50 
…rch#141106)

Summary: Pull Request resolved: pytorch#141106

Test Plan: CI

Differential Revision: D66204410
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2024

This pull request was exported from Phabricator. Differential Revision: D66204410

@marvin-kim marvin-kim changed the title Add missing annotation to stride in TensorMetadata Fix stride in TensorMetadata to always be a Tuple[int, ...] Nov 20, 2024
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2024
@ezyang
Copy link
Contributor

ezyang commented Nov 21, 2024

I'm not really seeing why this is an improvement. You will still out of bounds if you try indexing in it.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 21, 2024

This pull request was exported from Phabricator. Differential Revision: D66204410

@evanleed evanleed self-requested a review November 21, 2024 08:03
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 21, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@marvin-kim marvin-kim deleted the export-D66204410 branch November 21, 2024 17:35
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@marvin-kim @Ryo-not-rio
Fix stride in TensorMetadata to always be a Tuple[int, ...] (pyto…
89b327c 
…rch#141106)

Test Plan: CI

Differential Revision: D66204410

Pull Request resolved: pytorch#141106
Approved by: https://github.com/Skylion007, https://github.com/evanleed
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@marvin-kim
Fix stride in TensorMetadata to always be a Tuple[int, ...] (pyto…
376ff97 
…rch#141106)

Test Plan: CI

Differential Revision: D66204410

Pull Request resolved: pytorch#141106
Approved by: https://github.com/Skylion007, https://github.com/evanleed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@evanleed evanleed evanleed approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported fx Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marvin-kim @facebook-github-bot @ezyang @pytorchmergebot @Skylion007 @evanleed