Use std::bit_cast as c10::bit_cast if available #141035

swolchok · 2024-11-19T15:50:13Z

Stack from ghstack (oldest at bottom):

Make what we're doing as obvious as possible to the compiler.

Differential Revision: D66108811

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]

pytorch-bot · 2024-11-19T15:50:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141035

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[DomainsOnly] Jobs fail with GLIBC version not found

✅ No Failures

As of commit 7f3d535 with merge base 33191bb ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-11-19T15:50:28Z

This pull request was exported from Phabricator. Differential Revision: D66108811

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]

Pull Request resolved: #141035 Make what we're doing as obvious as possible to the compiler. ghstack-source-id: 254339612 @exported-using-ghexport Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/)

Skylion007 · 2024-11-19T15:57:40Z

c10/util/bit_cast.h

+#include <bit>
+#define C10_HAVE_STD_BIT_CAST 1
+#else
+#define C10_HAVE_STD_BIT_CAST 0


Similar logic to the prev PR. Does this macro serve any useful purpose. Main difference is whether bit_cast is constexpr I guess?

Generally speaking, it would be good to move those C10_HAVE_... macros to say c10/macros/Macros.h or define new Compiler.h there

As defining those in various headers can lead to a potential duplication and than divergence

I just wanted to avoid duplicating the condition in this file.

defining those in various headers

what other header would reasonably define or consume this? this is the bit_cast header.

I can update the diff to undefine its temporary macro

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]

facebook-github-bot · 2024-11-19T17:17:11Z

This pull request was exported from Phabricator. Differential Revision: D66108811

facebook-github-bot · 2024-11-19T17:17:34Z

This pull request was exported from Phabricator. Differential Revision: D66108811

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]

Pull Request resolved: #141035 Make what we're doing as obvious as possible to the compiler. ghstack-source-id: 254364210 @exported-using-ghexport Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/)

facebook-github-bot · 2024-11-19T17:54:21Z

This pull request was exported from Phabricator. Differential Revision: D66108811

swolchok · 2024-11-19T20:36:07Z

@pytorchbot merge

pytorchmergebot · 2024-11-19T20:38:02Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

- Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed

MatzeB · 2024-11-20T21:25:12Z

Getting build errors, does this need #include <bit>?

(Example: https://github.com/facebookresearch/FBGEMM/actions/runs/11939675144/job/33280696428?fbclid=IwZXh0bgNhZW0CMTEAAR0qw-Z0C82tyM2kL7NVQ4GXMI9qspha9PulW1rqQkgFrzRpDEMPHSiv6jE_aem_zAYroYhiJ8vq0b__z6yeiQ )

- Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed

MatzeB · 2024-11-20T21:27:16Z

(Seems the #include is already there, but something is failing here...)

MatzeB · 2024-11-20T21:35:42Z

c10/util/bit_cast.h


 #include <cstring>
 #include <type_traits>



This needs #include <version> before testing __cpp_lib_xxx.

(though I think this is unlikely the root cause of my build failures...)

- Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed - Deprecate support for CUDA 12.1 and add support for 12.6, per changes in pytorch/pytorch#138899

- Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed - Deprecate support for CUDA 12.1 and add initial support for 12.6, per changes in pytorch/pytorch#138899

Summary: X-link: facebookresearch/FBGEMM#486 - Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed - Deprecate support for CUDA 12.1 and add support for 12.6, per changes in pytorch/pytorch#138899 Pull Request resolved: #3398 Reviewed By: sryap Differential Revision: D66277492 Pulled By: q10 fbshipit-source-id: 24817efb5c07c1985ab3beeb1610879edbd81acc

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994

Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624

Summary: Pull Request resolved: facebookresearch/FBGEMM#486 - Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed - Deprecate support for CUDA 12.1 and add support for 12.6, per changes in pytorch/pytorch#138899 X-link: pytorch#3398 Reviewed By: sryap Differential Revision: D66277492 Pulled By: q10 fbshipit-source-id: 24817efb5c07c1985ab3beeb1610879edbd81acc

Use std::bit_cast as c10::bit_cast if available

c870837

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]

swolchok mentioned this pull request Nov 19, 2024

Fix Half X86_F16 CUDA build failure #140994

Closed

facebook-github-bot added the fb-exported label Nov 19, 2024

swolchok requested review from ezyang and malfet November 19, 2024 15:50

Skylion007 approved these changes Nov 19, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 19, 2024

Skylion007 reviewed Nov 19, 2024

View reviewed changes

ezyang approved these changes Nov 19, 2024

View reviewed changes

malfet approved these changes Nov 19, 2024

View reviewed changes

malfet added release notes: cpp release notes category topic: improvements topic category labels Nov 19, 2024

pytorchmergebot added the merging label Nov 19, 2024

pytorchmergebot added the Merged label Nov 19, 2024

pytorchmergebot closed this in f30f43f Nov 19, 2024

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 20, 2024

[fbgemm_gpu] Upgrade gcc version

7a5d11b

- Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed

q10 mentioned this pull request Nov 20, 2024

[fbgemm_gpu] OSS build updates pytorch/FBGEMM#3398

Closed

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 20, 2024

[fbgemm_gpu] Upgrade gcc version

b97b08b

- Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed

MatzeB reviewed Nov 20, 2024

View reviewed changes

github-actions bot deleted the gh/swolchok/701/head branch December 21, 2024 02:05

sarckk mentioned this pull request Dec 23, 2024

Update gcc version for FBGEMM install in CI meta-pytorch/torchrec#2654

Closed

Use std::bit_cast as c10::bit_cast if available #141035

Use std::bit_cast as c10::bit_cast if available #141035

Uh oh!

Conversation

swolchok commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141035

❗ 1 Active SEVs

✅ No Failures

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

Skylion007 Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

malfet Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

swolchok Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

swolchok commented Nov 19, 2024

Uh oh!

pytorchmergebot commented Nov 19, 2024

Merge started

Uh oh!

MatzeB commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MatzeB commented Nov 20, 2024

Uh oh!

MatzeB Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

swolchok commented Nov 19, 2024 •

edited

Loading

pytorch-bot bot commented Nov 19, 2024 •

edited

Loading

MatzeB commented Nov 20, 2024 •

edited

Loading

MatzeB Nov 20, 2024 •

edited

Loading