Fix Half X86_F16 CUDA build failure #140994
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140994
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 2bc42d0 with merge base 33191bb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66137897 |
swolchok
added a commit
that referenced
this pull request
Nov 19, 2024
It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) ghstack-source-id: 254235478 Pull Request resolved: #140994
Contributor
Author
|
@pytorchbot label "topic:not user facing" |
|
Didn't find following labels among repository labels: topic:not user facing |
malfet
approved these changes
Nov 19, 2024
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM, sounds like you are addressing feedback left at #140720 (comment)
It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66137897 |
It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66137897 |
Contributor
|
Oops, this have landed already, but it would be nice to highlight, that it not only broke internal builds, but other ecosystem libraries, fbgemm for example, see pytorch/FBGEMM#3394 (comment) |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: #141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567, #140720, #140994
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: pytorch#140994 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
It passed PyTorch CI, but internally we saw failures from this.
Differential Revision: D66137897